Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v3]

2024-11-21 Thread Roger Riggs
> Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) > > Refresh of PR#22168 Including review comments made there. Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev e

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-21 Thread Lance Andersen
On Wed, 20 Nov 2024 21:03:33 GMT, Roger Riggs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) >> >> Refresh of PR#22168 Including review comments made there. > > Roger Riggs has updated the pull request incrementally

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-21 Thread Daniel Fuchs
On Wed, 20 Nov 2024 21:03:33 GMT, Roger Riggs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) >> >> Refresh of PR#22168 Including review comments made there. > > Roger Riggs has updated the pull request incrementally

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-21 Thread Alan Bateman
On Wed, 20 Nov 2024 21:03:33 GMT, Roger Riggs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) >> >> Refresh of PR#22168 Including review comments made there. > > Roger Riggs has updated the pull request incrementally

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-20 Thread Roger Riggs
> Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) > > Refresh of PR#22168 Including review comments made there. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Remove

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-20 Thread Alan Bateman
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote: > Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) > > Refresh of PR#22168 Including review comments made there. I agree with Daniel that LOGGERFINDER_PERMISSION and the speci

RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-20 Thread Roger Riggs
Removed use of SecurityManager to check permissions. Relaxed defensive copying of byte arrays (due to lack of SM) Refresh of PR#22168 Including review comments made there. - Commit messages: - Refactor package private method `codeSource` into Module where it is used. - Review sugge

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-20 Thread Daniel Fuchs
On Wed, 20 Nov 2024 19:42:58 GMT, Roger Riggs wrote: > Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) > > Refresh of PR#22168 Including review comments made there. The changes to SystemLogger looks OK to me. Maybe you could ge

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-20 Thread Roger Riggs
On Mon, 18 Nov 2024 19:22:33 GMT, Roger Riggs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Rev

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v3]

2024-11-20 Thread Roger Riggs
> Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-19 Thread Alan Bateman
On Mon, 18 Nov 2024 19:22:33 GMT, Roger Riggs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Rev

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker [v2]

2024-11-18 Thread Roger Riggs
> Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Review suggestions applied: Remove SecurityExceptions from LiveStac

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-18 Thread Roger Riggs
On Mon, 18 Nov 2024 00:16:00 GMT, Chen Liang wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) > > src/java.base/share/classes/java/lang/String.java line 691: > >> 689: System.getSecurityManager() !=

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-18 Thread Roger Riggs
On Fri, 15 Nov 2024 22:43:13 GMT, Eirik Bjørsnøs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) > > src/java.base/share/classes/java/lang/System.java line 1336: > >> 1334: } >> 1335: >> 1336: private

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-17 Thread Chen Liang
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote: > Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) src/java.base/share/classes/java/lang/String.java line 691: > 689: System.getSecurityManager() != null)

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-16 Thread Alan Bateman
On Fri, 15 Nov 2024 22:41:22 GMT, Eirik Bjørsnøs wrote: >> Removed use of SecurityManager to check permissions. >> Relaxed defensive copying of byte arrays (due to lack of SM) > > src/java.base/share/classes/java/lang/String.java line 843: > >> 841: >> 842: // Trim the given byte array to t

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-15 Thread Eirik Bjørsnøs
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote: > Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) src/java.base/share/classes/java/lang/LiveStackFrame.java line 1: > 1: /* Seems you removed "@throws SecurityException" for

Re: RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-15 Thread Eirik Bjørsnøs
On Fri, 15 Nov 2024 22:11:17 GMT, Roger Riggs wrote: > Removed use of SecurityManager to check permissions. > Relaxed defensive copying of byte arrays (due to lack of SM) src/java.base/share/classes/java/lang/String.java line 843: > 841: > 842: // Trim the given byte array to the given len

RFR: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker

2024-11-15 Thread Roger Riggs
Removed use of SecurityManager to check permissions. Relaxed defensive copying of byte arrays (due to lack of SM) - Commit messages: - 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker Changes: https://git.openjdk.org/jdk/pull/22168/files Webrev: https://webrev