Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-30 Thread Alan Bateman
On Sun, 26 Jan 2025 07:30:22 GMT, Alan Bateman wrote: >>> Testing is still clean on my side. I would appreciate if folks can run this >>> through their CIs. >>> >>> I am planning to integrate this on Monday, as long as we discover no new >>> issues. >> >> Did the change to >> `test/jdk/sun/s

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-29 Thread Aleksey Shipilev
On Wed, 29 Jan 2025 19:42:49 GMT, Aleksey Shipilev wrote: >> src/java.base/share/classes/java/lang/ref/Reference.java line 282: >> >>> 280: * This method returns a strong reference to the referent. This >>> may cause >>> 281: * the garbage collector to treat it as strongly reachable u

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-29 Thread Brent Christian
On Wed, 29 Jan 2025 10:58:07 GMT, Aleksey Shipilev wrote: > > > Would you mind holding off until Tuesday to give time to get that done? > > > > > > Sure, there is no rush with this PR. I'll wait. > > How is it going, @AlanBateman? Any progress on closed tests? Nearly done - in review now. --

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-29 Thread Aleksey Shipilev
On Mon, 27 Jan 2025 09:08:56 GMT, Aleksey Shipilev wrote: > > Would you mind holding off until Tuesday to give time to get that done? > > Sure, there is no rush with this PR. I'll wait. How is it going, @AlanBateman? Any progress on closed tests? - PR Comment: https://git.openjdk.

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-27 Thread Aleksey Shipilev
On Sun, 26 Jan 2025 07:30:22 GMT, Alan Bateman wrote: > Would you mind holding off until Tuesday to give time to get that done? Sure, there is no rush with this PR. I'll wait. - PR Comment: https://git.openjdk.org/jdk/pull/22165#issuecomment-2615197062

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-25 Thread Alan Bateman
On Fri, 24 Jan 2025 22:01:59 GMT, Brent Christian wrote: > Testing is still clean on my side. I would appreciate if folks can run this > through their CIs. > > I am planning to integrate this on Monday, as long as we discover no new > issues. I ran it through our CI and we seem to have a few

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-24 Thread Aleksey Shipilev
On Fri, 24 Jan 2025 22:01:59 GMT, Brent Christian wrote: > Did the change to > `test/jdk/sun/security/provider/FileInputStreamPool/FileInputStreamPoolTest.java` > get lost? I'm pretty sure it was updated, but I no longer see that in the > changes, and it failed in my automated test run. It wa

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-24 Thread Brent Christian
On Fri, 24 Jan 2025 11:30:16 GMT, Aleksey Shipilev wrote: > Testing is still clean on my side. I would appreciate if folks can run this > through their CIs. > > I am planning to integrate this on Monday, as long as we discover no new > issues. Did the change to `test/jdk/sun/security/provide

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-24 Thread Aleksey Shipilev
On Thu, 23 Jan 2025 08:51:38 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-23 Thread Aleksey Shipilev
On Fri, 24 Jan 2025 00:09:00 GMT, Brent Christian wrote: >> Aleksey Shipilev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - No instantiation for BufferCleaner, javadocs >> - Remove hasReferencePendingList >> - Revert test exclusio

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-23 Thread Brent Christian
On Thu, 23 Jan 2025 08:51:38 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-23 Thread Brent Christian
On Thu, 23 Jan 2025 08:51:38 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-23 Thread Alan Bateman
On Thu, 23 Jan 2025 08:51:38 GMT, Aleksey Shipilev wrote: >> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` >> implementation. That implementation carries a doubly-linked list, and so >> makes DBB suffer from the same issue fixed for generic >> `java.lang.ref.Cleaner` users w

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-23 Thread Aleksey Shipilev
> DirectByteBuffers are still using old `jdk.internal.ref.Cleaner` > implementation. That implementation carries a doubly-linked list, and so > makes DBB suffer from the same issue fixed for generic > `java.lang.ref.Cleaner` users with > [JDK-8343704](https://bugs.openjdk.org/browse/JDK-8343704

Re: RFR: 8344332: (bf) Migrate DirectByteBuffer to use java.lang.ref.Cleaner [v9]

2025-01-23 Thread Aleksey Shipilev
On Wed, 22 Jan 2025 20:35:49 GMT, Brent Christian wrote: >> Aleksey Shipilev has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - No instantiation for BufferCleaner, javadocs >> - Remove hasReferencePendingList >> - Revert test exclusio