Re: RFR: 8344259: Annotate Float16 with jdk.internal.ValueBased

2024-11-15 Thread Paul Sandoz
On Fri, 15 Nov 2024 01:02:49 GMT, Joe Darcy wrote: > Looks fine; please manually verify the expected javac warnings are given for > misuse of Float16 in non-value ways. I manually and successfully tested compilation and execution of source that synchronized on an instance of Float16.

Re: RFR: 8344259: Annotate Float16 with jdk.internal.ValueBased

2024-11-14 Thread Joe Darcy
On Fri, 15 Nov 2024 00:25:20 GMT, Paul Sandoz wrote: > Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export > the package `jdk.internal` in module `java.base` to module` > jdk.incubator.vector`. > > Doing so enables the compiler and runtime to report warnings about improp

Re: RFR: 8344259: Annotate Float16 with jdk.internal.ValueBased

2024-11-14 Thread Chen Liang
On Fri, 15 Nov 2024 00:25:20 GMT, Paul Sandoz wrote: > Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export > the package `jdk.internal` in module `java.base` to module` > jdk.incubator.vector`. > > Doing so enables the compiler and runtime to report warnings about improp

RFR: 8344259: Annotate Float16 with jdk.internal.ValueBased

2024-11-14 Thread Paul Sandoz
Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export the package `jdk.internal` in module `java.base` to module` jdk.incubator.vector`. Doing so enables the compiler and runtime to report warnings about improper attempts to synchronize on instances of `Float16`, as describe