Re: RFR: 8344077: Remove security manager dependency in java.io [v4]

2024-11-19 Thread Brian Burkhalter
On Tue, 19 Nov 2024 16:53:27 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344077: Remove security manager dependency in java.io [v4]

2024-11-19 Thread Alan Bateman
On Tue, 19 Nov 2024 16:53:27 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344077: Remove security manager dependency in java.io [v4]

2024-11-19 Thread Roger Riggs
On Tue, 19 Nov 2024 16:53:27 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344077: Remove security manager dependency in java.io [v4]

2024-11-19 Thread Brian Burkhalter
> Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 836: Address reviewer comments - Changes: - all: https

Re: RFR: 8344077: Remove security manager dependency in java.io [v3]

2024-11-19 Thread Brian Burkhalter
On Tue, 19 Nov 2024 07:56:55 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 836: Revert spurious inclusion of SCTP changes > > src/java.base/share/classes/java/io/FileInputStream.java lin

Re: RFR: 8344077: Remove security manager dependency in java.io [v3]

2024-11-19 Thread Alan Bateman
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344077: Remove security manager dependency in java.io [v3]

2024-11-18 Thread Lance Andersen
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344077: Remove security manager dependency in java.io [v3]

2024-11-18 Thread Naoto Sato
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 834

Re: RFR: 8344077: Remove security manager dependency in java.io [v2]

2024-11-18 Thread Brian Burkhalter
On Mon, 18 Nov 2024 21:07:59 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with two > additional commits since the last revision: > > - 8

Re: RFR: 8344077: Remove security manager dependency in java.io [v3]

2024-11-18 Thread Brian Burkhalter
> Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 836: Revert spurious inclusion of SCTP changes - Changes

Re: RFR: 8344077: Remove security manager dependency in java.io [v2]

2024-11-18 Thread Naoto Sato
On Mon, 18 Nov 2024 21:07:59 GMT, Brian Burkhalter wrote: >> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `java.io` package. > > Brian Burkhalter has updated the pull request incrementally with two > additional commits since the last revision: > > - 8

Re: RFR: 8344077: Remove security manager dependency in java.io [v2]

2024-11-18 Thread Brian Burkhalter
On Mon, 18 Nov 2024 20:46:24 GMT, Roger Riggs wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 836: Address review comments >> - 836: Remove security manager dependency from module jdk.sctp > > src/ja

Re: RFR: 8344077: Remove security manager dependency in java.io [v2]

2024-11-18 Thread Brian Burkhalter
> Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. Brian Burkhalter has updated the pull request incrementally with two additional commits since the last revision: - 836: Address review comments - 836: Remove security manager dep

Re: RFR: 8344077: Remove security manager dependency in java.io [v2]

2024-11-18 Thread Brian Burkhalter
On Mon, 18 Nov 2024 20:56:59 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 836: Address review comments >> - 836: Remove security manager dependency from module jdk.sctp > > src/jav

Re: RFR: 8344077: Remove security manager dependency in java.io

2024-11-18 Thread Naoto Sato
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. src/java.base/share/classes/java/io/Console.java line 660: > 658: } > 659: > 660: @SuppressWarnings("removal") This too

Re: RFR: 8344077: Remove security manager dependency in java.io

2024-11-18 Thread Naoto Sato
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. `Console` changes look good to me, with a minor suggestion src/java.base/share/classes/java/io/Console.java line 687: > 685:

Re: RFR: 8344077: Remove security manager dependency in java.io

2024-11-18 Thread Roger Riggs
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. Looks good src/java.base/share/classes/java/io/FilePermission.java line 184: > 182: DefaultFileSystemProvider.theFileSys

Re: RFR: 8344077: Remove security manager dependency in java.io

2024-11-18 Thread Brian Burkhalter
On Mon, 18 Nov 2024 20:28:49 GMT, Brian Burkhalter wrote: > Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `java.io` package. Preliminary testing: the `jdk_io` tests pass on Linux and Windows. - PR Comment: https://git.openjdk.org/jdk/pull/22

RFR: 8344077: Remove security manager dependency in java.io

2024-11-18 Thread Brian Burkhalter
Expunge the use of the `SecurityManager`, `AccessController`, and the like from the `java.io` package. - Commit messages: - 8344077: Remove security manager dependency in java.io Changes: https://git.openjdk.org/jdk/pull/22219/files Webrev: https://webrevs.openjdk.org/?repo=jdk&p