Re: RFR: 8343984: Fix Unsafe address overflow [v8]

2024-11-13 Thread Alan Bateman
On Tue, 12 Nov 2024 23:34:48 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v8]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 23:34:48 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v8]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: Update src/java.base

Re: RFR: 8343984: Fix Unsafe address overflow [v7]

2024-11-12 Thread Andrey Turbanov
On Tue, 12 Nov 2024 16:30:12 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v6]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 15:54:00 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v7]

2024-11-12 Thread Chen Liang
On Tue, 12 Nov 2024 16:30:12 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v7]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 16:37:28 GMT, Shaojin Wen wrote: > @liach provided a new idea, which is to change the type of > jdk.internal.misc.Unsafe.ARRAY_XXX_OFFSET from int to long. I think @liach's > idea is better, that is the way to completely solve this problem. I discussed this briefly with him

Re: RFR: 8343984: Fix Unsafe address overflow [v7]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 16:30:12 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v7]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: fix copyright -

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 12:10:07 GMT, Alan Bateman wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename address to offset, from @AlanBateman > > Marked as reviewed by alanb (Reviewer). > @AlanBateman @minborg Sorry,

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 12:10:07 GMT, Alan Bateman wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename address to offset, from @AlanBateman > > Marked as reviewed by alanb (Reviewer). @AlanBateman @minborg Sorry, a

Re: RFR: 8343984: Fix Unsafe address overflow [v6]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: more fix unsafe addr

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 12:18:03 GMT, Per Minborg wrote: > I want to add such a test case, but I am worried that it will consume too > many resources during the build process. > > ```java > /** > * @test > * @bug 8343984 > * @summary Test that the append capacity is close to Integer.MaxValue >

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 11:24:24 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v5]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: rename address to of

Re: RFR: 8343984: Fix Unsafe address overflow [v4]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision: - re gen-src - rena

Re: RFR: 8343984: Fix Unsafe address overflow

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 07:30:41 GMT, Shaojin Wen wrote: > In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. There are two other possible address overflow issues that are difficult to f

Re: RFR: 8343984: Fix Unsafe address overflow [v3]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: from @minborg -

Re: RFR: 8343984: Fix Unsafe address overflow [v3]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 08:59:30 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v3]

2024-11-12 Thread Alan Bateman
On Tue, 12 Nov 2024 08:59:30 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v2]

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 08:26:44 GMT, Shaojin Wen wrote: >> In the JDK code, there are some places that may cause Unsafe offset >> overflow. The probability of occurrence is low, but if it occurs, it will >> cause JVM crash. > > Shaojin Wen has updated the pull request incrementally with one additi

Re: RFR: 8343984: Fix Unsafe address overflow [v2]

2024-11-12 Thread Shaojin Wen
On Tue, 12 Nov 2024 08:15:33 GMT, Per Minborg wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert, from @minborg > > src/java.base/share/classes/sun/nio/cs/StringUTF16.java line 35: > >> 33: public static ch

Re: RFR: 8343984: Fix Unsafe address overflow [v2]

2024-11-12 Thread Shaojin Wen
> In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: revert, from @minbor

Re: RFR: 8343984: Fix Unsafe address overflow

2024-11-12 Thread Per Minborg
On Tue, 12 Nov 2024 07:30:41 GMT, Shaojin Wen wrote: > In the JDK code, there are some places that may cause Unsafe offset overflow. > The probability of occurrence is low, but if it occurs, it will cause JVM > crash. src/java.base/share/classes/sun/nio/cs/StringUTF16.java line 35: > 33:

RFR: 8343984: Fix Unsafe address overflow

2024-11-11 Thread Shaojin Wen
In the JDK code, there are some places that may cause Unsafe offset overflow. The probability of occurrence is low, but if it occurs, it will cause JVM crash. - Commit messages: - fix unsafe address overflow Changes: https://git.openjdk.org/jdk/pull/22027/files Webrev: https://we