On Tue, 5 Nov 2024 16:08:20 GMT, Alexey Semenyuk wrote:
> - fix `JPackageCommand.excludeAppLayoutAsserts()`;
> - fix `InOutPath` test case that will make jpackage produce an invalid app
> image on macOS.
Hi Aleksei, with your patch added I see so far no errors any more related to
InOutPathTest
On Tue, 5 Nov 2024 22:42:13 GMT, Alexey Semenyuk wrote:
> can you try this fix in your environment?
Sure, I added the patch to our build/test queue .
-
PR Comment: https://git.openjdk.org/jdk/pull/21909#issuecomment-2458923465
On Tue, 5 Nov 2024 16:08:20 GMT, Alexey Semenyuk wrote:
> - fix `JPackageCommand.excludeAppLayoutAsserts()`;
> - fix `InOutPath` test case that will make jpackage produce an invalid app
> image on macOS.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://
On Tue, 5 Nov 2024 16:08:20 GMT, Alexey Semenyuk wrote:
> - fix `JPackageCommand.excludeAppLayoutAsserts()`;
> - fix `InOutPath` test case that will make jpackage produce an invalid app
> image on macOS.
@MBaesken can you try this fix in your environment?
-
PR Comment: https://git
On Tue, 5 Nov 2024 16:08:20 GMT, Alexey Semenyuk wrote:
> - fix `JPackageCommand.excludeAppLayoutAsserts()`;
> - fix `InOutPath` test case that will make jpackage produce an invalid app
> image on macOS.
@sashamatveev ptal
-
PR Comment: https://git.openjdk.org/jdk/pull/21909#issue
- fix `JPackageCommand.excludeAppLayoutAsserts()`;
- fix `InOutPath` test case that will make jpackage produce an invalid app
image on macOS.
-
Commit messages:
- Better wording of the comment
- One more try to make it work on OSX
- Bugfix for the case when `--app-content` is set
