Re: RFR: 8343236: Use @apiNote and @implNote in j.util.Currency

2024-10-31 Thread Iris Clark
On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu wrote: > Please review this PR which aims to improve the _j.util.Currency_ > specification by using `@apiNote` and `@implNote`. > > A corresponding CSR has been filed. Marked as reviewed by iris (Reviewer). - PR Review: https://git.open

Re: RFR: 8343236: Use @apiNote and @implNote in j.util.Currency

2024-10-31 Thread Naoto Sato
On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu wrote: > Please review this PR which aims to improve the _j.util.Currency_ > specification by using `@apiNote` and `@implNote`. > > A corresponding CSR has been filed. LGTM - Marked as reviewed by naoto (Reviewer). PR Review: https://g

Re: RFR: 8343236: Use @apiNote and @implNote in j.util.Currency

2024-10-30 Thread Brian Burkhalter
On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu wrote: > A corresponding CSR has been filed. Reviewed. - PR Comment: https://git.openjdk.org/jdk/pull/21793#issuecomment-2448853132

Re: RFR: 8343236: Use @apiNote and @implNote in j.util.Currency

2024-10-30 Thread Brian Burkhalter
On Wed, 30 Oct 2024 20:34:04 GMT, Justin Lu wrote: > Please review this PR which aims to improve the _j.util.Currency_ > specification by using `@apiNote` and `@implNote`. > > A corresponding CSR has been filed. Looks fine. - Marked as reviewed by bpb (Reviewer). PR Review: http

RFR: 8343236: Use @apiNote and @implNote in j.util.Currency

2024-10-30 Thread Justin Lu
Please review this PR which aims to improve the _j.util.Currency_ specification by using `@apiNote` and `@implNote`. A corresponding CSR has been filed. - Commit messages: - init Changes: https://git.openjdk.org/jdk/pull/21793/files Webrev: https://webrevs.openjdk.org/?repo=jdk&