Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-18 Thread Chen Liang
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-18 Thread duke
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry

2024-11-18 Thread Chen Liang
On Mon, 28 Oct 2024 06:05:50 GMT, Naman Nigam wrote: >> To get a JBS issue, please open a bug report about this typo in >> https://bugs.java.com/bugdatabase/. Also follow https://openjdk.org/guide >> for the rest of the steps for contributions. > >> To get a JBS issue, please open a bug report

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-14 Thread Stuart Marks
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-14 Thread Chen Liang
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-14 Thread Archie Cobbs
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-13 Thread Chen Liang
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v2]

2024-11-13 Thread Archie Cobbs
On Thu, 14 Nov 2024 03:19:01 GMT, Naman Nigam wrote: >> src/java.base/share/classes/java/util/TreeMap.java line 424: >> >>> 422: /** >>> 423: * Returns the entry for the least key greater than or equal to >>> the specified key; >>> 424: * if no such entry exists (i.e. the specifie

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]

2024-11-13 Thread Naman Nigam
> As the documentation of getCeilingEntry currently reads, the inference is > misleading as follows: > > if no such entry exists, returns the entry for the least key greater than the > specified key; > if no such entry exists (i.e., the greatest key in the Tree is less than the > specified key)

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v2]

2024-11-13 Thread Naman Nigam
On Thu, 14 Nov 2024 02:36:38 GMT, Archie Cobbs wrote: >> Naman Nigam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8343125 : Resolve a bad merge > > src/java.base/share/classes/java/util/TreeMap.java line 424: > >> 422: /** >>

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v2]

2024-11-13 Thread Archie Cobbs
On Thu, 14 Nov 2024 02:29:27 GMT, Naman Nigam wrote: >> As the documentation of getCeilingEntry currently reads, the inference is >> misleading as follows: >> >> if no such entry exists, returns the entry for the least key greater than >> the specified key; >> if no such entry exists (i.e., th

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v2]

2024-11-13 Thread Naman Nigam
On Wed, 13 Nov 2024 17:38:58 GMT, Chen Liang wrote: >> Naman Nigam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8343125 : Resolve a bad merge > > src/java.base/share/classes/java/util/TreeMap.java line 514: > >> 512:

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v2]

2024-11-13 Thread Naman Nigam
> As the documentation of getCeilingEntry currently reads, the inference is > misleading as follows: > > if no such entry exists, returns the entry for the least key greater than the > specified key; > if no such entry exists (i.e., the greatest key in the Tree is less than the > specified key)

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry

2024-11-13 Thread Chen Liang
On Sat, 26 Oct 2024 14:06:37 GMT, Naman Nigam wrote: > As the documentation of getCeilingEntry currently reads, the inference is > misleading as follows: > > if no such entry exists, returns the entry for the least key greater than the > specified key; > if no such entry exists (i.e., the grea

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry

2024-11-13 Thread Chen Liang
On Mon, 28 Oct 2024 06:05:50 GMT, Naman Nigam wrote: >> To get a JBS issue, please open a bug report about this typo in >> https://bugs.java.com/bugdatabase/. Also follow https://openjdk.org/guide >> for the rest of the steps for contributions. > >> To get a JBS issue, please open a bug report

RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry

2024-11-13 Thread Naman Nigam
As the documentation of getCeilingEntry currently reads, the inference is misleading as follows: if no such entry exists, returns the entry for the least key greater than the specified key; if no such entry exists (i.e., the greatest key in the Tree is less than the specified key), returns {@co

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry

2024-11-13 Thread Chen Liang
On Sat, 26 Oct 2024 14:06:37 GMT, Naman Nigam wrote: > As the documentation of getCeilingEntry currently reads, the inference is > misleading as follows: > > if no such entry exists, returns the entry for the least key greater than the > specified key; > if no such entry exists (i.e., the grea

Re: RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry

2024-11-13 Thread Naman Nigam
On Sun, 27 Oct 2024 02:30:33 GMT, Chen Liang wrote: > To get a JBS issue, please open a bug report about this typo in > https://bugs.java.com/bugdatabase/. Also follow https://openjdk.org/guide for > the rest of the steps for contributions. Thank you for your response @liach, I have - [x] file