Re: [jdk24] RFR: 8342465: Improve API documentation for java.lang.classfile

2025-01-27 Thread Chen Liang
On Mon, 27 Jan 2025 15:16:12 GMT, Chen Liang wrote: > Please review a non-clean backport of #23277, the final patch in the > improvements to the Class-File API. The backport is non-clean because a new > JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly. > > Tests: N

Re: [jdk24] RFR: 8342465: Improve API documentation for java.lang.classfile

2025-01-27 Thread Adam Sotona
On Mon, 27 Jan 2025 15:16:12 GMT, Chen Liang wrote: > Please review a non-clean backport of #23277, the final patch in the > improvements to the Class-File API. The backport is non-clean because a new > JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly. > > Tests: N

[jdk24] RFR: 8342465: Improve API documentation for java.lang.classfile

2025-01-27 Thread Chen Liang
Please review a non-clean backport of #23277, the final patch in the improvements to the Class-File API. The backport is non-clean because a new JAVA_25_VERSION constant was added in 25; otherwise the patch applied cleanly. Tests: Submitted tier 1-3 - Commit messages: - Backport 1

Re: RFR: 8342465: Improve API documentation for java.lang.classfile [v2]

2025-01-27 Thread Chen Liang
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote: >> This is the last piece in the API documentation improvement of the >> Class-File API. >> >> This includes general documentation about transforms, models (and >> traversals), options, constants, and CodeBuilder factories. In particular, >

Re: RFR: 8342465: Improve API documentation for java.lang.classfile [v2]

2025-01-27 Thread Adam Sotona
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote: >> This is the last piece in the API documentation improvement of the >> Class-File API. >> >> This includes general documentation about transforms, models (and >> traversals), options, constants, and CodeBuilder factories. In particular, >

Re: RFR: 8342465: Improve API documentation for java.lang.classfile [v2]

2025-01-24 Thread Joe Darcy
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote: >> This is the last piece in the API documentation improvement of the >> Class-File API. >> >> This includes general documentation about transforms, models (and >> traversals), options, constants, and CodeBuilder factories. In particular, >

Re: RFR: 8342465: Improve API documentation for java.lang.classfile [v2]

2025-01-24 Thread Chen Liang
On Fri, 24 Jan 2025 22:42:27 GMT, Chen Liang wrote: >> This is the last piece in the API documentation improvement of the >> Class-File API. >> >> This includes general documentation about transforms, models (and >> traversals), options, constants, and CodeBuilder factories. In particular, >

Re: RFR: 8342465: Improve API documentation for java.lang.classfile [v2]

2025-01-24 Thread Chen Liang
> This is the last piece in the API documentation improvement of the Class-File > API. > > This includes general documentation about transforms, models (and > traversals), options, constants, and CodeBuilder factories. In particular, > this preserves the package summary to avoid extra disrupti

Re: RFR: 8342465: Improve API documentation for java.lang.classfile

2025-01-24 Thread Adam Sotona
On Thu, 23 Jan 2025 19:48:55 GMT, Chen Liang wrote: > This is the last piece in the API documentation improvement of the Class-File > API. > > This includes general documentation about transforms, models (and > traversals), options, constants, and CodeBuilder factories. In particular, > this

RFR: 8342465: Improve API documentation for java.lang.classfile

2025-01-23 Thread Chen Liang
This is the last piece in the API documentation improvement of the Class-File API. This includes general documentation about transforms, models (and traversals), options, constants, and CodeBuilder factories. In particular, this preserves the package summary to avoid extra disruptions. See th