Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-15 Thread Brian Burkhalter
On Tue, 15 Oct 2024 13:06:01 GMT, Erik Joelsson wrote: > Test successful, thanks for fixing this! Thanks @erikj79 and @jaikiran for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/21503#issuecomment-2414642523

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-15 Thread Erik Joelsson
On Mon, 14 Oct 2024 23:26:04 GMT, Brian Burkhalter wrote: > > I'm taking this fix for a spin over night in the environment where I > > noticed the problem. > > I'll hold off integrating until that is over. Test successful, thanks for fixing this! - PR Comment: https://git.openjdk

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-15 Thread Jaikiran Pai
On Mon, 14 Oct 2024 18:02:44 GMT, Brian Burkhalter wrote: >> Change property `test.src` to `test.dir`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8341997: Replace test.dir property with CWD This test-only change l

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-14 Thread Brian Burkhalter
On Mon, 14 Oct 2024 23:07:28 GMT, Erik Joelsson wrote: > I'm taking this fix for a spin over night in the environment where I noticed > the problem. I'll hold off integrating until that is over. - PR Comment: https://git.openjdk.org/jdk/pull/21503#issuecomment-2412512411

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-14 Thread Erik Joelsson
On Mon, 14 Oct 2024 18:02:44 GMT, Brian Burkhalter wrote: >> Change property `test.src` to `test.dir`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8341997: Replace test.dir property with CWD I'm taking this fix for

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir

2024-10-14 Thread Erik Joelsson
On Mon, 14 Oct 2024 17:55:49 GMT, Brian Burkhalter wrote: > The property `test.dir` has been used as a convention but I've no problem > with changing it to the CWD. I wasn't aware, but if it's convention, I'm ok with it. - PR Comment: https://git.openjdk.org/jdk/pull/21503#issueco

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-14 Thread Erik Joelsson
On Mon, 14 Oct 2024 18:02:44 GMT, Brian Burkhalter wrote: >> Change property `test.src` to `test.dir`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8341997: Replace test.dir property with CWD Marked as reviewed by e

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir [v2]

2024-10-14 Thread Brian Burkhalter
> Change property `test.src` to `test.dir`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8341997: Replace test.dir property with CWD - Changes: - all: https://git.openjdk.org/jdk/pull/21503/files - new: https:

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir

2024-10-14 Thread Brian Burkhalter
On Mon, 14 Oct 2024 17:37:01 GMT, Brian Burkhalter wrote: > Change property `test.src` to `test.dir`. The property `test.dir` has been used as a convention but I've no problem with changing it to the CWD. - PR Comment: https://git.openjdk.org/jdk/pull/21503#issuecomment-2411903557

Re: RFR: 8341997: Tests create files in src tree instead of scratch dir

2024-10-14 Thread Erik Joelsson
On Mon, 14 Oct 2024 17:37:01 GMT, Brian Burkhalter wrote: > Change property `test.src` to `test.dir`. I can't find any reference to `test.dir` in the jtreg documentation. I would expect to see it here https://openjdk.org/jtreg/tag-spec.html#testvars. My understanding is that you should just us

RFR: 8341997: Tests create files in src tree instead of scratch dir

2024-10-14 Thread Brian Burkhalter
Change property `test.src` to `test.dir`. - Commit messages: - 8341997: Tests create files in src tree instead of scratch dir Changes: https://git.openjdk.org/jdk/pull/21503/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21503&range=00 Issue: https://bugs.openjdk.org/bro