Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v7]

2024-11-01 Thread Alan Bateman
On Fri, 1 Nov 2024 16:23:03 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull reques

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v7]

2024-11-01 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: -

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v6]

2024-10-29 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: Typo in comment. (Thanks, Roland!) - Changes: - all: https://git.openjdk.org/jdk/pull/21456/files - new: https://git.openjdk.org/

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v5]

2024-10-23 Thread Alan Bateman
On Wed, 23 Oct 2024 09:36:58 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > API change Marked as reviewed by alanb (Reviewer). - PR Review: ht

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v5]

2024-10-23 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: API change - Changes: - all: https://git.openjdk.org/jdk/pull/21456/files - new: https://git.openjdk.org/jdk/pull/21456/files/052

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v4]

2024-10-14 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v3]

2024-10-14 Thread Andrew Haley
On Mon, 14 Oct 2024 13:40:50 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request incrementally with two additional > commits since the last revision: > > - Scoped values > - Scoped values Tier1 and Tier2 done. I had one tier2 failure

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v3]

2024-10-14 Thread Alan Bateman
On Mon, 14 Oct 2024 13:40:50 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request incrementally with two additional > commits since the last revision: > > - Scoped values > - Scoped values The changes in update 90a344a3 looks okay, ju

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v3]

2024-10-14 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request incrementally with two additional commits since the last revision: - Scoped values - Scoped values - Changes: - all: https://git.openjdk.org/jdk/pull/21456/files - new: https://git.openjdk.org/jd

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Weijun Wang
On Thu, 10 Oct 2024 16:37:24 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Fix javadoc The one line change in `Subject.java` is fine. - PR Co

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Alan Bateman
On Thu, 10 Oct 2024 17:02:00 GMT, Alan Bateman wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix javadoc > > src/java.base/share/classes/java/lang/ScopedValue.java line 163: > >> 161: * // @link substri

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Alan Bateman
On Thu, 10 Oct 2024 16:37:24 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Fix javadoc @theRealAph The update to src/java.base/share/classes/jdk/internal/

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: Fix javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/21456/files - new: https://git.openjdk.org/jdk/pull/21456/files/77

RFR: 8341903: Implementation of Scoped Values (Fourth Preview)

2024-10-10 Thread Andrew Haley
The fourth preview of scoped values. - Commit messages: - Scoped Values API changes - Scoped Values API changes - Scoped Values API changes Changes: https://git.openjdk.org/jdk/pull/21456/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21456&range=00 Issue: https://bugs