Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v7]

2024-10-08 Thread Shaojin Wen
On Wed, 9 Oct 2024 04:20:17 GMT, Chen Liang wrote: > Back to precomputed constants :) Manual shift computation! The code is also simplified based on precomputed constants. - PR Comment: https://git.openjdk.org/jdk/pull/21399#issuecomment-2401334988

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v7]

2024-10-08 Thread Chen Liang
On Wed, 9 Oct 2024 04:09:33 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v7]

2024-10-08 Thread Shaojin Wen
> A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 Shaojin Wen has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v6]

2024-10-08 Thread Shaojin Wen
> A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 Shaojin Wen has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v5]

2024-10-08 Thread Claes Redestad
On Tue, 8 Oct 2024 22:34:38 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v5]

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 22:34:38 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v5]

2024-10-08 Thread Shaojin Wen
> A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 Shaojin Wen has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v4]

2024-10-08 Thread Shaojin Wen
> A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. T

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v3]

2024-10-08 Thread Claes Redestad
On Tue, 8 Oct 2024 18:35:46 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v3]

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 18:35:46 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v2]

2024-10-08 Thread Claes Redestad
On Tue, 8 Oct 2024 18:03:14 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java >> line 193: >> >>> 191: String argName = i < ARG_NAME_CACHE_SIZE ? ARG_NAME_CACHE[i] : >>> null; >>> 192: if (argName == null) { >>> 193:

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v3]

2024-10-08 Thread Shaojin Wen
> A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 Shaojin Wen has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v2]

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 17:35:32 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lazy initialization of ARG_NAME_CACHE > > src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v2]

2024-10-08 Thread Claes Redestad
On Tue, 8 Oct 2024 15:52:35 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v2]

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 15:52:35 GMT, Shaojin Wen wrote: >> A simple optimization that eliminates the allocation of the >> MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates >> the allocation of argNames when parameterCount is equal to 1 > > Shaojin Wen has updated the pull r

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory [v2]

2024-10-08 Thread Shaojin Wen
> A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 Shaojin Wen has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 00:47:27 GMT, Shaojin Wen wrote: > A simple optimization that eliminates the allocation of the > MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates > the allocation of argNames when parameterCount is equal to 1 `argNames[i]` is always `"arg$" + (i + 1

RFR: 8341755: Optimize argNames in InnerClassLambdaMetafactory

2024-10-08 Thread Shaojin Wen
A simple optimization that eliminates the allocation of the MethodTypeDescImpl object when parameterCount is equal to 0 and eliminates the allocation of argNames when parameterCount is equal to 1 - Commit messages: - Use global cache, don't need per-instance array - Merge remote-t