Re: RFR: 8340708: Optimize StackMapGenerator::processMethod [v3]

2024-09-24 Thread Chen Liang
On Tue, 24 Sep 2024 05:04:19 GMT, Shaojin Wen wrote: >> A small optimization of processMethod, by using local variables and >> extracting exception methods, reduces codeSize from 326 to 283 > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8340708: Optimize StackMapGenerator::processMethod [v3]

2024-09-23 Thread Shaojin Wen
> A small optimization of processMethod, by using local variables and > extracting exception methods, reduces codeSize from 326 to 283 Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: reduce getFrame - Changes: - all: h

Re: RFR: 8340708: Optimize StackMapGenerator::processMethod [v2]

2024-09-23 Thread Shaojin Wen
> A small optimization of processMethod, by using local variables and > extracting exception methods, reduces codeSize from 326 to 291 Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: suggestion from @liach - Changes: -

Re: RFR: 8340708: Optimize StackMapGenerator::processMethod

2024-09-23 Thread Chen Liang
On Mon, 23 Sep 2024 13:53:13 GMT, Shaojin Wen wrote: > A small optimization of processMethod, by using local variables and > extracting exception methods, reduces codeSize from 326 to 286 @wenshao Can you change the method to call generatorError? The ClassFormatError was a bug. -

Re: RFR: 8340708: Optimize StackMapGenerator::processMethod

2024-09-23 Thread Adam Sotona
On Mon, 23 Sep 2024 15:27:06 GMT, Chen Liang wrote: >> A small optimization of processMethod, by using local variables and >> extracting exception methods, reduces codeSize from 326 to 286 > > src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java > line 432: > >> 430:

Re: RFR: 8340708: Optimize StackMapGenerator::processMethod

2024-09-23 Thread Chen Liang
On Mon, 23 Sep 2024 13:53:13 GMT, Shaojin Wen wrote: > A small optimization of processMethod, by using local variables and > extracting exception methods, reduces codeSize from 326 to 286 src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java line 432: > 430:

RFR: 8340708: Optimize StackMapGenerator::processMethod

2024-09-23 Thread Shaojin Wen
A small optimization of processMethod, by using local variables and extracting exception methods, reduces codeSize from 326 to 286 - Commit messages: - Update src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java - optimize processMethod Changes: https://