Re: RFR: 8340623: Remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

2024-09-24 Thread Matthias Baesken
On Mon, 23 Sep 2024 08:05:55 GMT, Matthias Baesken wrote: > We still check for PROCESSOR_ARCHITECTURE_IA64 but this is not supported any > more for a very long time in OpenJDK. some wget failed in the Windows build, unrelated. - PR Comment: https://git.openjdk.org/jdk/pull/21130#i

Re: RFR: 8340623: Remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

2024-09-24 Thread David Holmes
On Mon, 23 Sep 2024 08:05:55 GMT, Matthias Baesken wrote: > We still check for PROCESSOR_ARCHITECTURE_IA64 but this is not supported any > more for a very long time in OpenJDK. Filed [JDK-8340731](https://bugs.openjdk.org/browse/JDK-8340731) for HS cleanup - PR Comment: https://gi

Re: RFR: 8340623: Remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

2024-09-23 Thread Matthias Baesken
On Mon, 23 Sep 2024 09:31:33 GMT, David Holmes wrote: > Seems fine. > > I thought we had eradicated ia64 from the codebase but it seems we missed a > few things in hotspot too. :( I will file an issue to clean that up ... Thanks for the reviews ! I noticed the HS ia64 references too but was n

Re: RFR: 8340623: remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

2024-09-23 Thread David Holmes
On Mon, 23 Sep 2024 08:05:55 GMT, Matthias Baesken wrote: > We still check for PROCESSOR_ARCHITECTURE_IA64 but this is not supported any > more for a very long time in OpenJDK. Seems fine. I thought we had eradicated ia64 from the codebase but it seems we missed a few things in hotspot too. :

Re: RFR: 8340623: remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

2024-09-23 Thread Alan Bateman
On Mon, 23 Sep 2024 08:05:55 GMT, Matthias Baesken wrote: > We still check for PROCESSOR_ARCHITECTURE_IA64 but this is not supported any > more for a very long time in OpenJDK. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/21130#pullrequestr

RFR: 8340623: remove outdated PROCESSOR_ARCHITECTURE_IA64 from Windows coding

2024-09-23 Thread Matthias Baesken
We still check for PROCESSOR_ARCHITECTURE_IA64 but this is not supported any more for a very long time in OpenJDK. - Commit messages: - JDK-8340623 Changes: https://git.openjdk.org/jdk/pull/21130/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21130&range=00 Issue: https