Re: RFR: 8339874: Avoid duplicate checking of trailing slash in ZipFile.getZipEntry [v5]

2024-09-12 Thread Claes Redestad
On Thu, 12 Sep 2024 11:28:20 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which speeds up `ZipFile.getZipEntry` by removing >> slash-checking logic which is already taking place during lookup in >> `ZipFile.Source.getEntryPos`. >> >> `ZipFile.Source.getEntryPos` includes logic to match

Re: RFR: 8339874: Avoid duplicate checking of trailing slash in ZipFile.getZipEntry [v5]

2024-09-12 Thread Eirik Bjørsnøs
On Thu, 12 Sep 2024 11:28:20 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which speeds up `ZipFile.getZipEntry` by removing >> slash-checking logic which is already taking place during lookup in >> `ZipFile.Source.getEntryPos`. >> >> `ZipFile.Source.getEntryPos` includes logic to match

Re: RFR: 8339874: Avoid duplicate checking of trailing slash in ZipFile.getZipEntry [v5]

2024-09-12 Thread Lance Andersen
On Thu, 12 Sep 2024 11:28:20 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which speeds up `ZipFile.getZipEntry` by removing >> slash-checking logic which is already taking place during lookup in >> `ZipFile.Source.getEntryPos`. >> >> `ZipFile.Source.getEntryPos` includes logic to match

Re: RFR: 8339874: Avoid duplicate checking of trailing slash in ZipFile.getZipEntry [v5]

2024-09-12 Thread Eirik Bjørsnøs
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing > slash-checking logic which is already taking place during lookup in > `ZipFile.Source.getEntryPos`. > > `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name" > against a directory entry "name/" (with