On Thu, 12 Sep 2024 11:28:20 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
>> slash-checking logic which is already taking place during lookup in
>> `ZipFile.Source.getEntryPos`.
>>
>> `ZipFile.Source.getEntryPos` includes logic to match
On Thu, 12 Sep 2024 11:28:20 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
>> slash-checking logic which is already taking place during lookup in
>> `ZipFile.Source.getEntryPos`.
>>
>> `ZipFile.Source.getEntryPos` includes logic to match
On Thu, 12 Sep 2024 11:28:20 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
>> slash-checking logic which is already taking place during lookup in
>> `ZipFile.Source.getEntryPos`.
>>
>> `ZipFile.Source.getEntryPos` includes logic to match
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
On Wed, 11 Sep 2024 08:34:09 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 681:
>>
>>> 679:
>>> 680: e.flag = CENFLG(cen, pos);
>>> 681: e.method = CENHOW(cen, pos);
>>
>> Not reading `nlen` when it's not needed is a good change, and
On Tue, 10 Sep 2024 19:39:34 GMT, Claes Redestad wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 681:
>
>> 679:
On Tue, 10 Sep 2024 19:39:24 GMT, Lance Andersen wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 161:
>
>> 159:
On Tue, 10 Sep 2024 19:57:56 GMT, Claes Redestad wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 549:
>
>> 547:
On Tue, 10 Sep 2024 19:34:11 GMT, Claes Redestad wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace per review feedback
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 161:
>
>> 159:
On Tue, 10 Sep 2024 19:30:52 GMT, Lance Andersen wrote:
> If this does not make a huge performance difference, I would keep this
> together with the init of elen and clen on line 692.
I verified this does not cause a regression, so moved the `nlen` read up on the
common path.
See also my comm
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
> against a directory entry "name/" (with
On Tue, 10 Sep 2024 18:35:52 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lo
On Tue, 10 Sep 2024 18:35:52 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lo
On Tue, 10 Sep 2024 18:35:52 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lo
On Tue, 10 Sep 2024 18:35:52 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which speeds up `ZipFile.getZipEntry` by removing
> slash-checking logic which is already taking place during lookup in
> `ZipFile.Source.getEntryPos`.
>
> `ZipFile.Source.getEntryPos` includes logic to match a lo
Please review this PR which speeds up `ZipFile.getZipEntry` by removing
slash-checking logic which is already taking place during lookup in
`ZipFile.Source.getEntryPos`.
`ZipFile.Source.getEntryPos` includes logic to match a lookup for "name"
against a directory entry "name/" (with a trailing
18 matches
Mail list logo
