On Tue, 29 Oct 2024 10:37:52 GMT, Alan Bateman wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Update VirtualMachineImpl_openProcess since it only needs to care about
>> 64-bit
On Tue, 29 Oct 2024 14:37:43 GMT, Aleksey Shipilev wrote:
>> @shipilev There _is_ a way to implement SpinPause on Windows/x64 though, if
>> support is really as simple as a single pause instruction. Should I help
>> implement this separately (After this PR is integrated, to avoid conflicts)?
>
On Tue, 29 Oct 2024 15:08:47 GMT, Magnus Ihse Bursie wrote:
>> src/hotspot/os/windows/os_windows.cpp line 2615:
>>
>>> 2613: Thread* t = Thread::current_or_null_safe();
>>> 2614:
>>> 2615: #if defined(_M_AMD64)
>>
>> The check for LP64 on line 2622 below seems redundant now
>
> Indeed, nice
On Tue, 29 Oct 2024 14:44:03 GMT, Magnus Ihse Bursie wrote:
>> I stand corrected: I forgot about Windows/ARM64. To correct myself: Due to a
>> bug, this file, which is meant for Windows/x64, is used by Windows/ARM64
>> instead. The consequences of this are unknown
>
> What bug are you referring
On Tue, 29 Oct 2024 13:14:44 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/sharedRuntimeRem.cpp line 28:
>>
>>> 26: #include "runtime/sharedRuntime.hpp"
>>> 27:
>>> 28: #ifdef _WIN64
>>
>> Just a heads up: Due to a bug, this entire file is never used at all
>
> I stand corrected: I forgo
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Tue, 29 Oct 2024 14:53:10 GMT, Julian Waters wrote:
>> What bug are you referring to that makes this file unused?
>
> https://mail.openjdk.org/pipermail/hotspot-dev/2024-October/095864.html
>
> This file isn't unused, I misspoke. Instead, it is meant as the
> implementation of frem and drem
On Tue, 29 Oct 2024 09:02:49 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove windows-only code guarded by _LP64.
>
> src/hotspot/os/windows/os_windows.cpp line 2615:
>
>> 2613: Thr
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Tue, 29 Oct 2024 09:34:09 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix NativeLookup::lookup_entry
>
> src/hotspot/share/prims/nativeLookup.cpp line 350:
>
>> 348: if (entry != n
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Tue, 29 Oct 2024 09:46:56 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Update VirtualMachineImpl_openProcess since it only needs to care about
>> 64-bit
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Mon, 28 Oct 2024 23:16:17 GMT, Erik Joelsson wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Use #error for unknown CPU
>> - Restore PLATFORM_CHECK_DEPRECATION
>
> make/modules/jdk.accessibility/Lib.gmk
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Tue, 29 Oct 2024 13:26:57 GMT, Julian Waters wrote:
>> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp line 523:
>>
>>> 521:
>>> 522: extern "C" int SpinPause () {
>>> 523: #ifdef AMD64
>>
>> Weird that SpinPause is not implemented on Win64, but oh well. This whole
>> SpinPause mess shou
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Tue, 29 Oct 2024 09:48:52 GMT, Aleksey Shipilev wrote:
>> I think it was needed when the name didn't match the src dir, due to the
>> `$1` suffix, but now we don't have that complication anymore.
>
> OK, good, as long as it was intentional.
Yes, Erik is correct.
-
PR Review Com
On Mon, 28 Oct 2024 19:25:09 GMT, Aleksey Shipilev wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> T
On Tue, 29 Oct 2024 06:59:22 GMT, Julian Waters wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> This
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Mon, 28 Oct 2024 19:17:54 GMT, Aleksey Shipilev wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> T
On Tue, 29 Oct 2024 09:32:21 GMT, David Holmes wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> This
On Mon, 28 Oct 2024 23:15:36 GMT, Erik Joelsson wrote:
>> make/modules/jdk.accessibility/Launcher.gmk line 56:
>>
>>> 54: $(eval $(call SetupJdkExecutable, BUILD_JACCESSINSPECTOR, \
>>> 55: NAME := jaccessinspector, \
>>> 56: EXTRA_SRC := \
>>
>> I might be missing something here.
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Mon, 28 Oct 2024 18:58:51 GMT, Aleksey Shipilev wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>> T
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Mon, 28 Oct 2024 18:15:38 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote:
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This
This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
Port_](https://openjdk.org/jeps/479).
This is the summary of JEP 479:
> Remove the source code and build support for the Windows 32-bit x86 port.
> This port was [deprecated for removal in JDK
> 21](https://openjdk.org/jeps/
32 matches
Mail list logo
