Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v6]

2024-09-17 Thread Shaojin Wen
On Tue, 10 Sep 2024 13:24:33 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line >> 529: >> >>> 527: mh = simpleConcat3(paramType0); >>> 528: mh = MethodHandles.insertArguments(mh, 0, prefix); >>> 529:

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v6]

2024-09-10 Thread Shaojin Wen
On Tue, 10 Sep 2024 10:28:56 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more 2 arguments simple concat > > src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line > 529:

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v6]

2024-09-10 Thread Claes Redestad
On Mon, 9 Sep 2024 17:20:44 GMT, Shaojin Wen wrote: >> The string concatenation of the java.base module is implemented using >> StringBuilder. By providing a series of concat methods in >> StringConcatHelper, it is used in the java.lang package to replace string >> concatenation. >> >> These

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v6]

2024-09-09 Thread Shaojin Wen
On Sun, 8 Sep 2024 16:37:08 GMT, Claes Redestad wrote: >> String concatenation is required in many places in java.lang. These static >> concat methods will be used instead of "+", so null value processing is >> added. This is also the motivation for using static concat methods instead >> of Co

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v6]

2024-09-09 Thread Shaojin Wen
> The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat methods can also be exposed through JLA for use by other