Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v5]

2024-10-15 Thread Jiangli Zhou
On Tue, 15 Oct 2024 18:50:27 GMT, Magnus Ihse Bursie wrote: > After thinking a bit more on this, I concluded that we cannot automatically > extract a proper set of ld flags from what's being passed to the individual > libraries. The LDFLAGS needed by the monolithic static library needs to be >

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v5]

2024-10-15 Thread Magnus Ihse Bursie
On Thu, 5 Sep 2024 20:41:35 GMT, Jiangli Zhou wrote: >> You are right, this is dead code. Thanks for spotting this. >> >> During my experimentation, I tried passing along LDFLAGS from the individual >> libraries as well, but it turned out not to be a good idea -- the way we >> have used them

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v5]

2024-10-15 Thread Magnus Ihse Bursie
On Thu, 5 Sep 2024 00:15:35 GMT, Jiangli Zhou wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update GetJREPath comment and remove unnecessary JLI_IsStaticallyLinked >> check > > src/java.base/unix/native/li

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v5]

2024-10-15 Thread Magnus Ihse Bursie
On Thu, 5 Sep 2024 10:17:11 GMT, Alan Bateman wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update GetJREPath comment and remove unnecessary JLI_IsStaticallyLinked >> check > > src/java.base/unix/native/li

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v5]

2024-10-15 Thread Magnus Ihse Bursie
> As a prerequisite for Hermetic Java, we need a statically linked `java` > launcher. It should behave like the normal, dynamically linked `java` > launcher, except that all JDK native libraries should be statically, not > dynamically, linked. > > This patch is the first step towards this goal.