Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-09 Thread John R Rose
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-09 Thread John R Rose
On Wed, 9 Oct 2024 16:07:19 GMT, Andrew Haley wrote: > simply(?) by allocating everything contiguously Suddenly I seem to hear Boromir and Yoda, in unison, saying, "One does not simply." - PR Comment: https://git.openjdk.org/jdk/pull/19157#issuecomment-2402756530

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-09 Thread Andrew Haley
On Wed, 9 Oct 2024 06:07:13 GMT, John R Rose wrote: > If the interfaces had a compact numbering, and there were a side table > mapping the compact numbers to interface Klass* pointers, then I think > Andrew's code would still work (with natural adjustments). Probably, yes. I can pack klass ID+

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-09 Thread Andrew Haley
On Wed, 9 Oct 2024 09:00:06 GMT, Andrew Haley wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replace Metaspace::is_compressed_klass_ptr with >> CompressedKlassPointers::is_in_encoding_range. > > On 10/9/24 0

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-09 Thread Andrew Haley
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-08 Thread John R Rose
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-08 Thread Quan Anh Mai
On Wed, 9 Oct 2024 05:53:51 GMT, Andrew Haley wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replace Metaspace::is_compressed_klass_ptr with >> CompressedKlassPointers::is_in_encoding_range. > > On 8 Oct 202

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-08 Thread Andrew Haley
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-10-08 Thread Andrew Haley
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-09-10 Thread Coleen Phillimore
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-09-10 Thread Thomas Stuefe
On Fri, 6 Sep 2024 16:20:52 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >> h

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v6]

2024-09-06 Thread Coleen Phillimore
> This change stores InstanceKlass for interface and abstract classes in the > non-class metaspace, since class metaspace will have limits on number of > classes that can be represented when Lilliput changes go in. Classes that > have no instances created for them don't require compressed class