Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads [v2]

2024-08-21 Thread Alan Bateman
On Wed, 21 Aug 2024 14:06:39 GMT, Doug Lea wrote: >> The Exchanger class uses spin-waits that are hostile to some uses of >> VirtualThreads. Improving this requires a means of estimating whether there >> are many VirtualThreads with few carriers, which can be supported by adding >> a method in

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-21 Thread Doug Lea
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a > method in cla

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads [v2]

2024-08-21 Thread Doug Lea
> The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a > method in class ForkJoinWorkerThread. This enables a reworking of

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-20 Thread Alan Bateman
On Tue, 20 Aug 2024 19:28:15 GMT, Doug Lea wrote: > However, it occurred to me that sometime soon, a version of the whole j.u.c > tck suite should be created to use virtual threads. Which would not be easy, > but might uncover something surprising? The j.u.c tests are run with JTREG_TEST_THRE

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-20 Thread Doug Lea
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a > method in cla

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-20 Thread Alan Bateman
On Mon, 19 Aug 2024 13:42:30 GMT, Viktor Klang wrote: > OK to merge from my perspective. Waiting for @AlanBateman to weigh in. Looks quite good, I'm just wondering if we should add some tests that exercise Exchanger with virtual threads (and a mix of virtual + platform threads). -

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-19 Thread Viktor Klang
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a > method in cla

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-13 Thread Doug Lea
On Tue, 13 Aug 2024 11:52:05 GMT, Viktor Klang wrote: >> The Exchanger class uses spin-waits that are hostile to some uses of >> VirtualThreads. Improving this requires a means of estimating whether there >> are many VirtualThreads with few carriers, which can be supported by adding >> a metho

Re: RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-13 Thread Viktor Klang
On Mon, 12 Aug 2024 17:07:42 GMT, Doug Lea wrote: > The Exchanger class uses spin-waits that are hostile to some uses of > VirtualThreads. Improving this requires a means of estimating whether there > are many VirtualThreads with few carriers, which can be supported by adding a > method in cla

RFR: 8338146: Improve Exchanger performance with VirtualThreads

2024-08-12 Thread Doug Lea
The Exchanger class uses spin-waits that are hostile to some uses of VirtualThreads. Improving this requires a means of estimating whether there are many VirtualThreads with few carriers, which can be supported by adding a method in class ForkJoinWorkerThread. This enables a reworking of the exc