Re: RFR: 8336934: Clean up JavaLangReflectAccess [v2]

2024-08-20 Thread Chen Liang
On Thu, 25 Jul 2024 22:33:44 GMT, Chen Liang wrote: >> Removed redundant APIs in `JavaLangReflectAccess` and added general warning >> against using `SharedSecrets`. >> >> The cleanup in `JavaLangReflectAccess` is: >> - Converted `newConstructor` taking parameters to taking another constructor

Re: RFR: 8336934: Clean up JavaLangReflectAccess [v2]

2024-08-20 Thread Joe Darcy
On Thu, 25 Jul 2024 22:33:44 GMT, Chen Liang wrote: >> Removed redundant APIs in `JavaLangReflectAccess` and added general warning >> against using `SharedSecrets`. >> >> The cleanup in `JavaLangReflectAccess` is: >> - Converted `newConstructor` taking parameters to taking another constructor

Re: RFR: 8336934: Clean up JavaLangReflectAccess [v2]

2024-07-26 Thread Roger Riggs
On Thu, 25 Jul 2024 22:33:44 GMT, Chen Liang wrote: >> Removed redundant APIs in `JavaLangReflectAccess` and added general warning >> against using `SharedSecrets`. >> >> The cleanup in `JavaLangReflectAccess` is: >> - Converted `newConstructor` taking parameters to taking another constructor

Re: RFR: 8336934: Clean up JavaLangReflectAccess

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 21:45:21 GMT, Roger Riggs wrote: >> Removed redundant APIs in `JavaLangReflectAccess` and added general warning >> against using `SharedSecrets`. >> >> The cleanup in `JavaLangReflectAccess` is: >> - Converted `newConstructor` taking parameters to taking another constructor

Re: RFR: 8336934: Clean up JavaLangReflectAccess [v2]

2024-07-25 Thread Chen Liang
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning > against using `SharedSecrets`. > > The cleanup in `JavaLangReflectAccess` is: > - Converted `newConstructor` taking parameters to taking another constructor > and a new accessor. The old existing API essentially does

Re: RFR: 8336934: Clean up JavaLangReflectAccess

2024-07-25 Thread Chen Liang
On Thu, 25 Jul 2024 21:38:04 GMT, Roger Riggs wrote: >> Removed redundant APIs in `JavaLangReflectAccess` and added general warning >> against using `SharedSecrets`. > > src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java > line 53: > >> 51: // >> 52: >> 53: //

Re: RFR: 8336934: Clean up JavaLangReflectAccess

2024-07-25 Thread Roger Riggs
On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang wrote: > Removed redundant APIs in `JavaLangReflectAccess` and added general warning > against using `SharedSecrets`. src/java.base/share/classes/java/lang/reflect/Constructor.java line 168: > 166: } > 167: > 168: /** Creates a new root con

Re: RFR: 8336934: Clean up JavaLangReflectAccess

2024-07-25 Thread Roger Riggs
On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang wrote: > Removed redundant APIs in `JavaLangReflectAccess` and added general warning > against using `SharedSecrets`. The description should include a summary of the changes and the rationale. The Jira description is a bit better and could also be mo

RFR: 8336934: Clean up JavaLangReflectAccess

2024-07-22 Thread Chen Liang
Removed redundant APIs in `JavaLangReflectAccess` and added general warning against using `SharedSecrets`. - Commit messages: - 8336934: Clean up JavaLangReflectAccess Changes: https://git.openjdk.org/jdk/pull/20290/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20290&ran