Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v3]

2024-09-06 Thread Chen Liang
On Wed, 21 Aug 2024 15:42:18 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v3]

2024-08-21 Thread Coleen Phillimore
On Wed, 21 Aug 2024 15:42:18 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v3]

2024-08-21 Thread Coleen Phillimore
On Wed, 21 Aug 2024 15:42:18 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v3]

2024-08-21 Thread Chen Liang
> Move fields common to Method and Field to executable, which simplifies > implementation. Removed useless transient modifiers as Method and Field were > never serializable. > > Note to core-libs reviewers: Please review the associated CSR on trivial > removal of `abstract` modifier as well. C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-08-19 Thread Chen Liang
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-08-19 Thread Joe Darcy
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-07-17 Thread Chen Liang
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. >> >> Note to core-libs reviewers: Please review the associated C

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-07-16 Thread David Holmes
On Wed, 17 Jul 2024 02:57:51 GMT, Chen Liang wrote: >> What would be the terminology for a final field that's set by hotspot, >> against the regular java constrcutor rules? > > I have chosen the wording "all final fields are used by the VM" I don't know of any specific terminology - we typicall

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-07-16 Thread David Holmes
On Wed, 17 Jul 2024 03:03:23 GMT, Chen Liang wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. > > Chen Liang has updated the pull request incrementally with one

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-07-16 Thread Chen Liang
On Tue, 16 Jul 2024 22:41:40 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 54: >> >>> 52: public abstract sealed class Executable extends AccessibleObject >>> 53: implements Member, GenericDeclaration permits Constructor, Method { >>> 54: //

Re: RFR: 8336275: Move common Method and Constructor fields to Executable [v2]

2024-07-16 Thread Chen Liang
> Move fields common to Method and Field to executable, which simplifies > implementation. Removed useless transient modifiers as Method and Field were > never serializable. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: Redundant tr

Re: RFR: 8336275: Move common Method and Constructor fields to Executable

2024-07-16 Thread Chen Liang
On Tue, 16 Jul 2024 22:00:49 GMT, David Holmes wrote: >> Move fields common to Method and Field to executable, which simplifies >> implementation. Removed useless transient modifiers as Method and Field were >> never serializable. > > src/java.base/share/classes/java/lang/reflect/Executable.jav

Re: RFR: 8336275: Move common Method and Constructor fields to Executable

2024-07-16 Thread David Holmes
On Tue, 16 Jul 2024 03:45:36 GMT, Chen Liang wrote: > Move fields common to Method and Field to executable, which simplifies > implementation. Removed useless transient modifiers as Method and Field were > never serializable. Hotspot changes look good. Core-libs do too but I will leave that fo

Re: RFR: 8336275: Move common Method and Constructor fields to Executable

2024-07-16 Thread David Holmes
On Tue, 16 Jul 2024 03:45:36 GMT, Chen Liang wrote: > Move fields common to Method and Field to executable s/Field/Constructor I was a bit confused about executable fields for a moment. :) - PR Comment: https://git.openjdk.org/jdk/pull/20188#issuecomment-2231889229

RFR: 8336275: Move common Method and Constructor fields to Executable

2024-07-15 Thread Chen Liang
Move fields common to Method and Field to executable, which simplifies implementation. Removed useless transient modifiers as Method and Field were never serializable. - Commit messages: - Inline some common ctor + method fields to executable Changes: https://git.openjdk.org/jdk/p