Re: [jdk23] RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-15 Thread Pavel Rappo
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote: > Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and > erroneous links in the doc files. Marked as reviewed by prappo (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20166#pullrequestreview-217806

Re: [jdk23] RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-15 Thread Chen Liang
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote: > Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and > erroneous links in the doc files. Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/20166#issuecomment-2228806864

Re: [jdk23] RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-15 Thread Iris Clark
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote: > Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and > erroneous links in the doc files. Confirmed identical to original PR. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/

[jdk23] RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-12 Thread Chen Liang
Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and erroneous links in the doc files. - Commit messages: - Backport 5bc86f332986e3fffc1363f569029bb73a706064 Changes: https://git.openjdk.org/jdk/pull/20166/files Webrev: https://webrevs.openjdk.org/?repo=jdk&p

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-12 Thread Chen Liang
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread duke
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread Nizar Benalla
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread Chen Liang
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

Re: RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread Jonathan Gibbons
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote: > Can I please get a review for this small change, the relative link to the > stylesheet isn't needed as it wasn't used anyway in the generated HTML. The > correct link to the stylesheet is already in the generated HTML. > > This is the di

RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

2024-07-11 Thread Nizar Benalla
Can I please get a review for this small change, the relative link to the stylesheet isn't needed as it wasn't used anyway in the generated HTML. The correct link to the stylesheet is already in the generated HTML. This is the difference between the generated docs before and after this change,