Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v5]

2024-08-13 Thread Chen Liang
On Fri, 2 Aug 2024 16:31:48 GMT, Chen Liang wrote: >> 1. Add notes and docs about the difference between resolved constants and >> constant pool descriptors for annotation constants (e.g. `char` vs >> `IntegerEntry`) >> 2. Improved value specification to specify their tags. >> 3. Improved value

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v5]

2024-08-12 Thread Adam Sotona
On Fri, 2 Aug 2024 16:31:48 GMT, Chen Liang wrote: >> 1. Add notes and docs about the difference between resolved constants and >> constant pool descriptors for annotation constants (e.g. `char` vs >> `IntegerEntry`) >> 2. Improved value specification to specify their tags. >> 3. Improved value

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v5]

2024-08-02 Thread Chen Liang
> 1. Add notes and docs about the difference between resolved constants and > constant pool descriptors for annotation constants (e.g. `char` vs > `IntegerEntry`) > 2. Improved value specification to specify their tags. > 3. Improved value factories to return their specific types instead of > `O

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v4]

2024-08-02 Thread Chen Liang
> 1. Add notes and docs about the difference between resolved constants and > constant pool descriptors for annotation constants (e.g. `char` vs > `IntegerEntry`) > 2. Improved value specification to specify their tags. > 3. Improved value factories to return their specific types instead of > `O

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v3]

2024-08-02 Thread Chen Liang
> 1. Add notes and docs about the difference between resolved constants and > constant pool descriptors for annotation constants (e.g. `char` vs > `IntegerEntry`) > 2. Improved value specification to specify their tags. > 3. Improved value factories to return their specific types instead of > `O

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v2]

2024-08-02 Thread Chen Liang
On Fri, 2 Aug 2024 07:57:27 GMT, Adam Sotona wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits si

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant [v2]

2024-08-02 Thread Chen Liang
> 1. Add notes and docs about the difference between resolved constants and > constant pool descriptors for annotation constants (e.g. `char` vs > `IntegerEntry`) > 2. Improved value specification to specify their tags. > 3. Improved value factories to return their specific types instead of > `O

Re: RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

2024-08-02 Thread Adam Sotona
On Fri, 2 Aug 2024 00:39:12 GMT, Chen Liang wrote: > 1. Add notes and docs about the difference between resolved constants and > constant pool descriptors for annotation constants (e.g. `char` vs > `IntegerEntry`) > 2. Improved value specification to specify their tags. > 3. Improved value fact

RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

2024-08-01 Thread Chen Liang
1. Add notes and docs about the difference between resolved constants and constant pool descriptors for annotation constants (e.g. `char` vs `IntegerEntry`) 2. Improved value specification to specify their tags. 3. Improved value factories to return their specific types instead of `OfConstant` 4

RFR: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

2024-07-14 Thread Chen Liang
Remove `AnnotationConstantValueEntry` and `AnnotationValue.OfConstant`. This is a relic of the old model from https://github.com/openjdk/jdk-sandbox/commit/bb7e29474ecfcfbd1eb01d237593eb80d062944f. In addition, this is bug-prone: the byte, short, char, and boolean constants use the int entry, a