Re: RFR: 8335668: NumberFormat integer only parsing should throw exception for edge case [v2]

2024-07-10 Thread Naoto Sato
On Tue, 9 Jul 2024 20:29:48 GMT, Justin Lu wrote: >> Please review this PR which corrects a case in NumberFormat integer only >> parsing. >> >> [JDK-8333755](https://bugs.openjdk.org/browse/JDK-8333755) fixed integer >> only parsing when the value has a suffix, although it caused incorrect >>

Re: RFR: 8335668: NumberFormat integer only parsing should throw exception for edge case [v2]

2024-07-09 Thread Justin Lu
On Tue, 9 Jul 2024 19:41:29 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reflect review > > test/jdk/java/text/Format/NumberFormat/LenientParseTest.java line 146: > >> 144: @EnabledIfSystemProp

Re: RFR: 8335668: NumberFormat integer only parsing should throw exception for edge case [v2]

2024-07-09 Thread Justin Lu
> Please review this PR which corrects a case in NumberFormat integer only > parsing. > > [JDK-8333755](https://bugs.openjdk.org/browse/JDK-8333755) fixed integer only > parsing when the value has a suffix, although it caused incorrect behavior > for the following case: when the parsed string d

Re: RFR: 8335668: NumberFormat integer only parsing should throw exception for edge case

2024-07-09 Thread Naoto Sato
On Tue, 9 Jul 2024 18:42:25 GMT, Justin Lu wrote: > Please review this PR which corrects a case in NumberFormat integer only > parsing. > > [JDK-8333755](https://bugs.openjdk.org/browse/JDK-8333755) fixed integer only > parsing when the value has a suffix, although it caused incorrect behavior

RFR: 8335668: NumberFormat integer only parsing should throw exception for edge case

2024-07-09 Thread Justin Lu
Please review this PR which corrects a case in NumberFormat integer only parsing. [JDK-8333755](https://bugs.openjdk.org/browse/JDK-8333755) fixed integer only parsing when the value has a suffix, although it caused incorrect behavior for the following case: when the parsed string does not cont