Re: RFR: 8335642: Hide Transform implementation for Class-File API [v3]

2024-07-15 Thread Chen Liang
On Sun, 14 Jul 2024 13:49:09 GMT, Chen Liang wrote: >> Removes ClassFile API transformation implementation details accidentally >> leaked to public API. Users don't have access to classes necessary to >> correctly implement these transform resolutions. In addition, removed >> improper `canWrit

Re: RFR: 8335642: Hide Transform implementation for Class-File API [v3]

2024-07-14 Thread Adam Sotona
On Sun, 14 Jul 2024 13:49:09 GMT, Chen Liang wrote: >> Removes ClassFile API transformation implementation details accidentally >> leaked to public API. Users don't have access to classes necessary to >> correctly implement these transform resolutions. In addition, removed >> improper `canWrit

Re: RFR: 8335642: Hide Transform implementation for Class-File API [v2]

2024-07-14 Thread Chen Liang
On Wed, 10 Jul 2024 07:30:36 GMT, Adam Sotona wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> return tag required > > Looks good to me. > Nice cleanup job! @asotona I have fixed the merge conflict (imports) and reru

Re: RFR: 8335642: Hide Transform implementation for Class-File API [v3]

2024-07-14 Thread Chen Liang
> Removes ClassFile API transformation implementation details accidentally > leaked to public API. Users don't have access to classes necessary to > correctly implement these transform resolutions. In addition, removed > improper `canWriteDirect` and made `ClassFileBuilder::transform` chain > r

Re: RFR: 8335642: Hide Transform implementation for Class-File API [v2]

2024-07-10 Thread Adam Sotona
On Tue, 9 Jul 2024 19:00:45 GMT, Chen Liang wrote: >> Removes ClassFile API transformation implementation details accidentally >> leaked to public API. Users don't have access to classes necessary to >> correctly implement these transform resolutions. In addition, removed >> improper `canWrite

Re: RFR: 8335642: Hide Transform implementation for Class-File API [v2]

2024-07-09 Thread Chen Liang
> Removes ClassFile API transformation implementation details accidentally > leaked to public API. Users don't have access to classes necessary to > correctly implement these transform resolutions. In addition, removed > improper `canWriteDirect` and made `ClassFileBuilder::transform` chain > r

RFR: 8335642: Hide Transform implementation for Class-File API

2024-07-09 Thread Chen Liang
Removes ClassFile API transformation implementation details accidentally leaked to public API. Users don't have access to classes necessary to correctly implement these transform resolutions. In addition, removed improper `canWriteDirect` and made `ClassFileBuilder::transform` chain returns. Re