Re: RFR: 8335366: Improve String.format performance with fastpath [v14]

2024-07-27 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v13]

2024-07-05 Thread Shaojin Wen
On Tue, 2 Jul 2024 14:04:52 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatter

Re: RFR: 8335366: Improve String.format performance with fastpath [v13]

2024-07-04 Thread Chen Liang
On Tue, 2 Jul 2024 14:04:52 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatter

Re: RFR: 8335366: Improve String.format performance with fastpath [v13]

2024-07-03 Thread Shaojin Wen
On Tue, 2 Jul 2024 14:04:52 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatter

Re: RFR: 8335366: Improve String.format performance with fastpath [v13]

2024-07-02 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v12]

2024-07-02 Thread Roger Riggs
On Mon, 1 Jul 2024 19:17:50 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatter

Re: RFR: 8335366: Improve String.format performance with fastpath [v12]

2024-07-01 Thread Shaojin Wen
On Mon, 1 Jul 2024 19:17:50 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatter

Re: RFR: 8335366: Improve String.format performance with fastpath [v5]

2024-07-01 Thread David Schlosnagle
On Mon, 1 Jul 2024 16:28:09 GMT, ExE Boss wrote: >> j.u.Formatter supports args == null > > When `args == null` or `args.length == 0`, then the format string can still > contain `%%` or `%n`, and those will be formatted to `"%"` and  > [`System​.lineSeparator()`] respectively. > > [`System​.lin

Re: RFR: 8335366: Improve String.format performance with fastpath [v12]

2024-07-01 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v5]

2024-07-01 Thread ExE Boss
On Sat, 29 Jun 2024 19:10:51 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/lang/StringFormat.java line 48: >> >>> 46: static String format(String format, Object... args) { >>> 47: if (args != null) { >>> 48: int off = format.indexOf('%'); >> >> nit: instead

Re: RFR: 8335366: Improve String.format performance with fastpath [v11]

2024-07-01 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v11]

2024-07-01 Thread Shaojin Wen
On Mon, 1 Jul 2024 12:53:42 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatter

Re: RFR: 8335366: Improve String.format performance with fastpath [v10]

2024-07-01 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v9]

2024-07-01 Thread Claes Redestad
On Mon, 1 Jul 2024 06:18:55 GMT, Chen Liang wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> code style > > As promising as the performance number is, I think we need to ensure two > things: > 1. Correctness: this p

Re: RFR: 8335366: Improve String.format performance with fastpath [v9]

2024-06-30 Thread Chen Liang
On Sun, 30 Jun 2024 18:21:52 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatte

Re: RFR: 8335366: Improve String.format performance with fastpath [v9]

2024-06-30 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v8]

2024-06-30 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v7]

2024-06-30 Thread David Schlosnagle
On Sun, 30 Jun 2024 04:54:35 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatte

Re: RFR: 8335366: Improve String.format performance with fastpath [v7]

2024-06-30 Thread David Schlosnagle
On Sun, 30 Jun 2024 14:57:26 GMT, David Schlosnagle wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> laze init for `decimal fast path locale` > > src/java.base/share/classes/java/lang/StringFormat.java line 142: > >

Re: RFR: 8335366: Improve String.format performance with fastpath [v7]

2024-06-30 Thread Shaojin Wen
On Sun, 30 Jun 2024 04:54:35 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatte

Re: RFR: 8335366: Improve String.format performance with fastpath [v7]

2024-06-29 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v6]

2024-06-29 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v5]

2024-06-29 Thread Shaojin Wen
On Sat, 29 Jun 2024 19:05:18 GMT, David Schlosnagle wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> private method & field > > src/java.base/share/classes/java/lang/StringFormat.java line 48: > >> 46: static St

Re: RFR: 8335366: Improve String.format performance with fastpath [v5]

2024-06-29 Thread David Schlosnagle
On Sat, 29 Jun 2024 18:59:33 GMT, Shaojin Wen wrote: >> We need a String format solution with good performance. String Template was >> once expected, but it has been removed. j.u.Formatter is powerful, but its >> performance is not good enough. >> >> This PR implements a subset of j.u.Formatte

Re: RFR: 8335366: Improve String.format performance with fastpath [v5]

2024-06-29 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v4]

2024-06-29 Thread Shaojin Wen
On Sat, 29 Jun 2024 17:41:47 GMT, David Schlosnagle wrote: >> src/java.base/share/classes/java/lang/StringFormat.java line 82: >> >>> 80: conv = format.charAt(off + 2); >>> 81: } >>> 82: } >> >> is it worth handling `width > 9`? >> >> Suggestion: >> >>

Re: RFR: 8335366: Improve String.format performance with fastpath [v4]

2024-06-29 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v3]

2024-06-29 Thread David Schlosnagle
On Sat, 29 Jun 2024 16:16:51 GMT, David Schlosnagle wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename `digit` to `width` > > src/java.base/share/classes/java/lang/StringFormat.java line 82: > >> 80:

Re: RFR: 8335366: Improve String.format performance with fastpath [v3]

2024-06-29 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath [v2]

2024-06-29 Thread Shaojin Wen
On Sat, 29 Jun 2024 16:17:32 GMT, David Schlosnagle wrote: >> Shaojin Wen has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Update src/java.base/share/classes/java/lang/StringFormat.java >> >>Co-authored-by: David Schlosnagle >

Re: RFR: 8335366: Improve String.format performance with fastpath [v2]

2024-06-29 Thread Shaojin Wen
> We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter capabilities. The performance is > good enough that it is

Re: RFR: 8335366: Improve String.format performance with fastpath

2024-06-29 Thread David Schlosnagle
On Sat, 29 Jun 2024 11:53:31 GMT, Shaojin Wen wrote: > We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter cap

Re: RFR: 8335366: Improve String.format performance with fastpath

2024-06-29 Thread Glavo
On Sat, 29 Jun 2024 11:53:31 GMT, Shaojin Wen wrote: > We need a String format solution with good performance. String Template was > once expected, but it has been removed. j.u.Formatter is powerful, but its > performance is not good enough. > > This PR implements a subset of j.u.Formatter cap

RFR: 8335366: Improve String.format performance with fastpath

2024-06-29 Thread Shaojin Wen
We need a String format solution with good performance. String Template was once expected, but it has been removed. j.u.Formatter is powerful, but its performance is not good enough. This PR implements a subset of j.u.Formatter capabilities. The performance is good enough that it is a fastpath