Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-10 Thread fabioromano1
On Tue, 9 Jul 2024 18:14:03 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure normalized value in MutableBigInteger initialization with ints > > Everything not obvious that departs fr

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-09 Thread fabioromano1
On Tue, 9 Jul 2024 18:14:03 GMT, Raffaello Giulietti wrote: > Everything not obvious that departs from the paper by Bertot, Magaud and > Zimmermann should be commented. Unfortunately, I can't say precisely what and > to which extent until I see a first version. @rgiulietti Well. Regarding the

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-09 Thread Raffaello Giulietti
On Tue, 2 Jul 2024 01:44:43 GMT, fabioromano1 wrote: >> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-09 Thread fabioromano1
On Tue, 9 Jul 2024 18:04:43 GMT, Raffaello Giulietti wrote: > These helpful considerations, and others that are not obvious when comparing > with the paper, should really be part of comments in the code. As mentioned, > this helps with reviewing and for maintenance. @rgiulietti I will add the

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-09 Thread Raffaello Giulietti
On Tue, 2 Jul 2024 01:44:43 GMT, fabioromano1 wrote: >> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-09 Thread fabioromano1
On Tue, 9 Jul 2024 17:17:48 GMT, Raffaello Giulietti wrote: > Let's agree that the reference for this PR is the > [algorithm](https://inria.hal.science/inria-00072113/document) described by > Bertot, Magaud and Zimmermann. > > From a first reading, the algorithm implemented here appears diffe

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-09 Thread Raffaello Giulietti
On Tue, 2 Jul 2024 01:44:43 GMT, fabioromano1 wrote: >> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v21]

2024-07-01 Thread fabioromano1
> I have implemented the Zimmermann's square root algorithm, available in works > [here](https://inria.hal.science/inria-00072854/en/) and > [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). > > The algorithm is proved to be asymptotically faster than the New