Re: RFR: 8334714: Implement JEP 484: Class-File API [v6]

2024-09-30 Thread Adam Sotona
On Fri, 27 Sep 2024 16:29:30 GMT, ExE Boss wrote: > I wish that the concrete `PoolEntry` subtypes had `of(…)` factory methods... Please forward the proposal on clasfile-api-dev mailing list, where it can be discussed. Thank you. - PR Comment: https://git.openjdk.org/jdk/pull/19826

Re: RFR: 8334714: Implement JEP 484: Class-File API [v6]

2024-09-27 Thread ExE Boss
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona wrote: >> Class-File API is leaving preview. >> This is a removal of all `@PreviewFeature` annotations from Class-File API. >> It also bumps all `@since` tags and removes >> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`. >> >> Please rev

Re: RFR: 8334714: Implement JEP 484: Class-File API [v6]

2024-09-26 Thread Adam Sotona
On Thu, 26 Sep 2024 17:11:24 GMT, Nizar Benalla wrote: > I ran it and all the tags seem to be correct. Thank you! - PR Comment: https://git.openjdk.org/jdk/pull/19826#issuecomment-2377551118

Re: RFR: 8334714: Implement JEP 484: Class-File API [v6]

2024-09-26 Thread Nizar Benalla
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona wrote: >> Class-File API is leaving preview. >> This is a removal of all `@PreviewFeature` annotations from Class-File API. >> It also bumps all `@since` tags and removes >> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`. >> >> Please rev

Re: RFR: 8334714: Implement JEP 484: Class-File API [v6]

2024-09-26 Thread Chen Liang
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona wrote: >> Class-File API is leaving preview. >> This is a removal of all `@PreviewFeature` annotations from Class-File API. >> It also bumps all `@since` tags and removes >> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`. >> >> Please rev

Re: RFR: 8334714: Implement JEP 484: Class-File API [v6]

2024-09-26 Thread Adam Sotona
> Class-File API is leaving preview. > This is a removal of all `@PreviewFeature` annotations from Class-File API. > It also bumps all `@since` tags and removes > `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull re