Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-25 Thread Hamlin Li
On Tue, 25 Jun 2024 12:51:46 GMT, Ludovic Henry wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This is similar with previous JDK-8334396. >> Added some tests. >> >> ### Test >> >>   | Tests | Scores | Errors | Unit >> -- | -- | -- | -- | -- >> Intrinsic, +zbb, +rvv | Char

Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-25 Thread Ludovic Henry
On Tue, 25 Jun 2024 08:12:53 GMT, Hamlin Li wrote: >> test/micro/org/openjdk/bench/java/lang/Characters.java line 69: >> >>> 67: >>> 68: @Benchmark >>> 69: public void reverseBytes() { >> >> I'm not sure we want to be adding that benchmark to this class. Could you >> move to a differe

Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-25 Thread Ludovic Henry
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote: > Hi, > Can you help to review this patch? > Thanks! > > This is similar with previous JDK-8334396. > Added some tests. > > ### Test > >   | Tests | Scores | Errors | Unit > -- | -- | -- | -- | -- > Intrinsic, +zbb, +rvv | Characters.reverseBy

Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-25 Thread Hamlin Li
On Mon, 24 Jun 2024 21:01:14 GMT, Ludovic Henry wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This is similar with previous JDK-8334396. >> Added some tests. >> >> ### Test >> >>   | Tests | Scores | Errors | Unit >> -- | -- | -- | -- | -- >> Intrinsic, +zbb, +rvv | Char

Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-24 Thread Ludovic Henry
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote: > Hi, > Can you help to review this patch? > Thanks! > > This is similar with previous JDK-8334396. > Added some tests. > > ### Test > >   | Tests | Scores | Errors | Unit > -- | -- | -- | -- | -- > Intrinsic, +zbb, +rvv | Characters.reverseBy

Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-23 Thread Fei Yang
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote: > Hi, > Can you help to review this patch? > Thanks! > > This is similar with previous JDK-8334396. > Added some tests. > > ### Test > >   | Tests | Scores | Errors | Unit > -- | -- | -- | -- | -- > Intrinsic, +zbb, +rvv | Characters.reverseBy

RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-21 Thread Hamlin Li
Hi, Can you help to review this patch? Thanks! This is similar with previous JDK-8334396. Added some tests. ### Test   | Tests | Scores | Errors | Unit -- | -- | -- | -- | -- Intrinsic, +zbb, +rvv | Characters.reverseBytes | 1654.535 | 69.36 | ns/op   | Shorts.reverseBytes | 1795.403 | 44.015 |