Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-25 Thread Tobias Hartmann
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-25 Thread Emanuel Peter
On Wed, 24 Jul 2024 21:59:52 GMT, Shaojin Wen wrote: >> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits sin

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-24 Thread duke
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-24 Thread Emanuel Peter
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-24 Thread Shaojin Wen
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-24 Thread Shaojin Wen
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v7]

2024-07-24 Thread Shaojin Wen
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incrementa

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v6]

2024-07-24 Thread Emanuel Peter
On Wed, 24 Jul 2024 13:33:43 GMT, Chen Liang wrote: >> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> commits sinc

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v5]

2024-07-24 Thread Emanuel Peter
On Tue, 18 Jun 2024 01:09:49 GMT, Shaojin Wen wrote: >> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits sin

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v6]

2024-07-24 Thread Chen Liang
On Thu, 18 Jul 2024 00:52:17 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v6]

2024-07-17 Thread Shaojin Wen
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incrementa

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v5]

2024-06-17 Thread Shaojin Wen
On Mon, 17 Jun 2024 23:02:47 GMT, Shaojin Wen wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > Shaojin Wen has updated the pull request with

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v5]

2024-06-17 Thread Shaojin Wen
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incrementa

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v4]

2024-06-17 Thread Emanuel Peter
On Mon, 17 Jun 2024 08:07:40 GMT, Shaojin Wen wrote: >> test/micro/org/openjdk/bench/java/lang/MergeStoreBench.java line 656: >> >>> 654: array[offset + 2] = (byte) (value >> 8); >>> 655: array[offset + 3] = (byte) (value ); >>> 656: } >> >> You say that here `MergeSto

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v4]

2024-06-17 Thread Shaojin Wen
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v3]

2024-06-17 Thread Shaojin Wen
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8334342: Add MergeStore JMH benchmarks [v2]

2024-06-17 Thread Shaojin Wen
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. Shaojin Wen has updated the pull request incrementally with four additional commits since the last revisio

Re: RFR: 8334342: Add MergeStore JMH benchmarks

2024-06-17 Thread Shaojin Wen
On Mon, 17 Jun 2024 07:44:33 GMT, Emanuel Peter wrote: >> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We >> need a JMH Benchmark to evaluate the performance of various batch operations >> and the effect of MergeStore. > > test/micro/org/openjdk/bench/java/lang/Merge

Re: RFR: 8334342: Add MergeStore JMH benchmarks

2024-06-17 Thread Emanuel Peter
On Sun, 16 Jun 2024 07:17:16 GMT, Shaojin Wen wrote: > [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. A few extra comments: There is already a `MergeStore

RFR: 8334342: Add MergeStore JMH benchmarks

2024-06-16 Thread Shaojin Wen
[8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We need a JMH Benchmark to evaluate the performance of various batch operations and the effect of MergeStore. - Commit messages: - code format - add `setIntRL` & `setIntRLU` - add comments - add comments -

Re: RFR: 8334342: Add MergeStore JMH benchmarks

2024-06-16 Thread Shaojin Wen
On Sun, 16 Jun 2024 07:17:16 GMT, Shaojin Wen wrote: > [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We > need a JMH Benchmark to evaluate the performance of various batch operations > and the effect of MergeStore. # 1. Cases MergeStore does not work >From the resul