Re: RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix [v3]

2024-06-13 Thread Naoto Sato
On Wed, 12 Jun 2024 21:58:25 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920) >> which corrects a bug where NumberFormat cannot successfully parse values in >> integer only mode, when the format expects a suffix. >> >> For example, >> >> //

Re: RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix [v2]

2024-06-12 Thread Justin Lu
On Wed, 12 Jun 2024 20:12:15 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> specification improvements > > src/java.base/share/classes/java/text/DecimalFormat.java line 2446: > >> 2444: // To tra

Re: RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix [v3]

2024-06-12 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920) > which corrects a bug where NumberFormat cannot successfully parse values in > integer only mode, when the format expects a suffix. > > For example, > > // a format that expects a currency suffix > var fmt = NumberF

Re: RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix [v2]

2024-06-12 Thread Naoto Sato
On Wed, 12 Jun 2024 17:06:25 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920) >> which corrects a bug where NumberFormat cannot successfully parse values in >> integer only mode, when the format expects a suffix. >> >> For example, >> >> //

Re: RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix [v2]

2024-06-12 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920) > which corrects a bug where NumberFormat cannot successfully parse values in > integer only mode, when the format expects a suffix. > > For example, > > // a format that expects a currency suffix > var fmt = NumberF

RFR: 8333755: NumberFormat integer only parsing breaks when format has suffix

2024-06-11 Thread Justin Lu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920) which corrects a bug where NumberFormat cannot successfully parse values in integer only mode, when the format expects a suffix. For example, // a format that expects a currency suffix var fmt = NumberFormat.getCurrenc