Re: RFR: 8333582: Update CLDR to Version 46.0 [v2]

2024-11-04 Thread Naoto Sato
On Thu, 31 Oct 2024 20:06:24 GMT, Naoto Sato wrote: >> Upgrading the CLDR to version 46.0. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addresses review comments Thank you fo

Re: RFR: 8333582: Update CLDR to Version 46.0 [v2]

2024-11-01 Thread Naoto Sato
On Fri, 1 Nov 2024 20:10:02 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addresses review comments > > test/jdk/sun/text/resources/LocaleDataTest.java line 44: > >> 42: * 8209775 8221432 82271

Re: RFR: 8333582: Update CLDR to Version 46.0 [v2]

2024-11-01 Thread Joe Wang
On Thu, 31 Oct 2024 20:06:24 GMT, Naoto Sato wrote: >> Upgrading the CLDR to version 46.0. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addresses review comments Looks good t

Re: RFR: 8333582: Update CLDR to Version 46.0 [v2]

2024-10-31 Thread Naoto Sato
> Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Addresses review comments - Changes: - all: https://git.openjdk.org/jdk/pull/21772/files

Re: RFR: 8333582: Update CLDR to Version 46.0

2024-10-31 Thread Naoto Sato
On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato wrote: > Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. Thanks, Justin > Left minor comments. They are both leftovers. Removed. - PR Comment: https://git.openjdk.org/jdk/pull/21772#issuecomment-245071671

Re: RFR: 8333582: Update CLDR to Version 46.0

2024-10-31 Thread Justin Lu
On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato wrote: > Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. Data changes look to be CLDR 46. Went through the tests as well. Change in build to add the aliases of the preferred value for a deprecated zone LGTM. Left minor

RFR: 8333582: Update CLDR to Version 46.0

2024-10-30 Thread Naoto Sato
Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. - Commit messages: - .md files - cldr46 release - CLDR-17960: updating tzdata to 2024b - CLDR-15697: First day of week is Monday in UAE - canonical tzname fallback - Deprecated short tzid to preferred

Re: RFR: 8333582: Update CLDR to Version 46.0

2024-10-30 Thread Steven Loomis
On Tue, 29 Oct 2024 18:12:43 GMT, Naoto Sato wrote: > Upgrading the CLDR to version 46.0. A corresponding CSR has also been drafted. Spot checked the data and tests. Checked the provider changes, all LGTM. - Marked as reviewed by srl (Committer). PR Review: https://git.openjdk.org