Re: RFR: 8333396: Performance regression of DecimalFormat.format [v3]

2024-06-04 Thread kuaiwei
On Tue, 4 Jun 2024 08:58:38 GMT, lingjun-cg wrote: > > > > Hi, I think you can add the jmh test case. > > > > > > > > > [#19513 > > > (comment)](https://github.com/openjdk/jdk/pull/19513#issue-2330131051) > > > already contains the test case. > > > > > > I mean it can be added as a test cas

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v3]

2024-06-04 Thread lingjun-cg
On Tue, 4 Jun 2024 07:54:56 GMT, kuaiwei wrote: > > > Hi, I think you can add the jmh test case. > > > > > > [#19513 > > (comment)](https://github.com/openjdk/jdk/pull/19513#issue-2330131051) > > already contains the test case. > > I mean it can be added as a test case in test/micro and be e

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v3]

2024-06-04 Thread kuaiwei
On Tue, 4 Jun 2024 02:18:49 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v3]

2024-06-04 Thread lingjun-cg
On Tue, 4 Jun 2024 07:21:15 GMT, kuaiwei wrote: > Hi, I think you can add the jmh test case. https://github.com/openjdk/jdk/pull/19513#issue-2330131051 already contains the test case. - PR Comment: https://git.openjdk.org/jdk/pull/19513#issuecomment-2146844849

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v3]

2024-06-04 Thread kuaiwei
On Tue, 4 Jun 2024 02:18:49 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: RFR: 8333396: Performance regression of DecimalFormat.format [v3]

2024-06-03 Thread lingjun-cg
> ### Performance regression of DecimalFormat.format > From the output of perf, we can see the hottest regions contain atomic > instructions. But when run with JDK 11, there is no such problem. The reason > is the removed biased locking. > The DecimalFormat uses StringBuffer everywhere, and St