On Thu, 6 Jun 2024 17:08:50 GMT, Naoto Sato wrote:
>> test/jdk/java/io/Console/restoreEcho.exp line 57:
>>
>>> 55: test "$rpprompt" "$rpinput" "-echo" "$rpexpected"
>>> 56: # See if the initialEcho is restored with `stty -a`
>>> 57: expect " $initialEcho "
>>
>> If you leave out those whitespac
On Thu, 6 Jun 2024 17:51:50 GMT, Naoto Sato wrote:
> Turned out that removing the classpath ends up not finding the test class:
>
> ```
> Error: Could not find or load main class RestoreEchoTest
> Caused by: java.lang.ClassNotFoundException: RestoreEchoTest
> ];
> ```
Hm... this is surprising.
On Thu, 6 Jun 2024 17:08:45 GMT, Naoto Sato wrote:
>> test/jdk/java/io/Console/RestoreEchoTest.java line 72:
>>
>>> 70: "--add-opens=java.base/jdk.internal.io=ALL-UNNAMED",
>>> 71: "-Djdk.console=java.base",
>>> 72: "-classpath", testClasses,
>>
>
On Thu, 6 Jun 2024 09:05:23 GMT, Pavel Rappo wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unnecessary add-opens
>
> test/jdk/java/io/Console/RestoreEchoTest.java line 66:
>
>> 64: OutputAnalyzer o
On Wed, 5 Jun 2024 17:48:25 GMT, Naoto Sato wrote:
>> This test intends to verify the behavior of JdkConsole for the java.base
>> module, wrt restoring the echo. The test assumes the internal methods that
>> sets/gets the echo status of the platform.
>
> Naoto Sato has updated the pull request
On Wed, 5 Jun 2024 17:48:25 GMT, Naoto Sato wrote:
>> This test intends to verify the behavior of JdkConsole for the java.base
>> module, wrt restoring the echo. The test assumes the internal methods that
>> sets/gets the echo status of the platform.
>
> Naoto Sato has updated the pull request
> This test intends to verify the behavior of JdkConsole for the java.base
> module, wrt restoring the echo. The test assumes the internal methods that
> sets/gets the echo status of the platform.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last re
