Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v4]

2024-07-03 Thread duke
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HTM

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v4]

2024-07-03 Thread Aleksei Efimov
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HTM

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v4]

2024-07-03 Thread Nizar Benalla
On Tue, 2 Jul 2024 16:24:49 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HTM

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v3]

2024-07-02 Thread Nizar Benalla
On Tue, 2 Jul 2024 15:09:49 GMT, Aleksei Efimov wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve package description based on Efimov's suggestion > > src/java.naming/share/classes/javax/naming/event/packag

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v4]

2024-07-02 Thread Nizar Benalla
> Can I please get a review for this small change? The motivation is that javac > does not recognize `package.html` files. > > The conversion was simple, I used a script to rename the files, append "*" on > the left and remove some HTML tags like `` and ``. I did the > conversion in place, rena

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v3]

2024-07-02 Thread Aleksei Efimov
On Fri, 28 Jun 2024 10:44:05 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HT

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-28 Thread Nizar Benalla
On Thu, 27 Jun 2024 10:27:03 GMT, Aleksei Efimov wrote: >> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> comm

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v3]

2024-06-28 Thread Nizar Benalla
> Can I please get a review for this small change? The motivation is that javac > does not recognize `package.html` files. > > The conversion was simple, I used a script to rename the files, append "*" on > the left and remove some HTML tags like `` and ``. I did the > conversion in place, rena

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-27 Thread Aleksei Efimov
On Wed, 26 Jun 2024 20:41:56 GMT, Jonathan Gibbons wrote: >> src/java.naming/share/classes/javax/naming/ldap/package-info.java line 200: >> >>> 198: * if (respCtls != null) { >>> 199: * // Find the one we want >>> 200: * for (int i = 0; i < respCtls.length; i++) { >> >> This is the o

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-27 Thread Aleksei Efimov
On Wed, 26 Jun 2024 18:11:45 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HT

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-26 Thread Jonathan Gibbons
On Wed, 26 Jun 2024 18:08:21 GMT, Nizar Benalla wrote: >> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commi

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-26 Thread Nizar Benalla
> Can I please get a review for this small change? The motivation is that javac > does not recognize `package.html` files. > > The conversion was simple, I used a script to rename the files, append "*" on > the left and remove some HTML tags like `` and ``. I did the > conversion in place, rena

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java [v2]

2024-06-26 Thread Nizar Benalla
On Wed, 26 Jun 2024 18:09:10 GMT, Nizar Benalla wrote: >> Can I please get a review for this small change? The motivation is that >> javac does not recognize `package.html` files. >> >> The conversion was simple, I used a script to rename the files, append "*" >> on the left and remove some HT

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java

2024-06-04 Thread Nizar Benalla
On Mon, 3 Jun 2024 17:26:52 GMT, Nizar Benalla wrote: > Can I please get a review for this small change? The motivation is that javac > does not recognize `package.html` files. > > The conversion was simple, I used a script to rename the files, append "*" on > the left and remove some HTML tag

Re: RFR: 8332072: Convert package.html files in `java.naming` to package-info.java

2024-06-03 Thread Joe Darcy
On Mon, 3 Jun 2024 17:26:52 GMT, Nizar Benalla wrote: > Can I please get a review for this small change? The motivation is that javac > does not recognize `package.html` files. > > The conversion was simple, I used a script to rename the files, append "*" on > the left and remove some HTML tag

RFR: 8332072: Convert package.html files in `java.naming` to package-info.java

2024-06-03 Thread Nizar Benalla
Can I please get a review for this small change? The motivation is that javac does not recognize `package.html` files. The conversion was simple, I used a script to rename the files, append "*" on the left and remove some HTML tags like and . I did the conversion in place, renaming them in git