Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException [v2]

2024-05-15 Thread Daniel Fuchs
On Mon, 13 May 2024 23:59:17 GMT, Viktor Klang wrote: >> This change adds wrapping of the CancellationException produced by >> CompletableFuture::get() and CompletableFuture::join() to add more >> diagnostic information and align better with FutureTask. >> >> Running the sample code from the J

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException [v2]

2024-05-14 Thread Alan Bateman
On Mon, 13 May 2024 23:59:17 GMT, Viktor Klang wrote: >> This change adds wrapping of the CancellationException produced by >> CompletableFuture::get() and CompletableFuture::join() to add more >> diagnostic information and align better with FutureTask. >> >> Running the sample code from the J

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException [v2]

2024-05-13 Thread Viktor Klang
> This change adds wrapping of the CancellationException produced by > CompletableFuture::get() and CompletableFuture::join() to add more diagnostic > information and align better with FutureTask. > > Running the sample code from the JBS issue in JShell will produce the > following: > > > jsh

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException [v2]

2024-05-13 Thread Viktor Klang
On Mon, 13 May 2024 18:16:55 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/CompletableFuture.java line >> 392: >> >>> 390: return null; >>> 391: if (x instanceof CancellationException) >>> 392: throw new CancellationExceptio

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException

2024-05-13 Thread Doug Lea
On Mon, 13 May 2024 17:06:10 GMT, Viktor Klang wrote: >> This change adds wrapping of the CancellationException produced by >> CompletableFuture::get() and CompletableFuture::join() to add more >> diagnostic information and align better with FutureTask. >> >> Running the sample code from the J

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException

2024-05-13 Thread Chen Liang
On Mon, 13 May 2024 16:41:37 GMT, Viktor Klang wrote: > This change adds wrapping of the CancellationException produced by > CompletableFuture::get() and CompletableFuture::join() to add more diagnostic > information and align better with FutureTask. > > Running the sample code from the JBS is

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException

2024-05-13 Thread Viktor Klang
On Mon, 13 May 2024 16:41:37 GMT, Viktor Klang wrote: > This change adds wrapping of the CancellationException produced by > CompletableFuture::get() and CompletableFuture::join() to add more diagnostic > information and align better with FutureTask. > > Running the sample code from the JBS is

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException

2024-05-13 Thread Viktor Klang
On Mon, 13 May 2024 17:03:00 GMT, Chen Liang wrote: >> This change adds wrapping of the CancellationException produced by >> CompletableFuture::get() and CompletableFuture::join() to add more >> diagnostic information and align better with FutureTask. >> >> Running the sample code from the JBS

Re: RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException

2024-05-13 Thread Viktor Klang
On Mon, 13 May 2024 16:41:37 GMT, Viktor Klang wrote: > This change adds wrapping of the CancellationException produced by > CompletableFuture::get() and CompletableFuture::join() to add more diagnostic > information and align better with FutureTask. > > Running the sample code from the JBS is

RFR: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException

2024-05-13 Thread Viktor Klang
This change adds wrapping of the CancellationException produced by CompletableFuture::get() and CompletableFuture::join() to add more diagnostic information and align better with FutureTask. Running the sample code from the JBS issue in JShell will produce the following: jshell> java.util.conc