On Thu, 2 May 2024 21:19:14 GMT, Phil Race wrote:
> I see you added test.lib.Platform.isOnWayland() in this PR
> https://github.com/openjdk/jdk/pull/18995/files#diff-a1fe81399728999601f16ae9aaf5caae27f009c394377d2cd86c71f6d5e0e54c
>
> So, that helps me understand why it is a new problem, but I
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
Marked as reviewed by prr (Reviewer).
OK. I see. The problem is that the test is out of sync with the actual usage of
Platform.
Arguably isOnWayland() and all these others should be in some OTHER class
entirely.
Some
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
I see you added test.lib.Platform.isOnWayland() in this PR
https://github.com/openjdk/jdk/pull/18995/files#diff-a1fe81399728999601f16ae9aaf5caae27f009c394377d2cd86c71f6d5e0e54c
So, that helps me understand why it is a
On Thu, 2 May 2024 21:05:38 GMT, Alexander Zvegintsev
wrote:
> Trivial fix.
I'd love to approve this but could you please explain what this is about ?
I see the failure log in the bug report but I am none the wiser.
Why exactly is this a problem ?
-
PR Comment: https://git.openjd
Trivial fix.
-
Commit messages:
- initial
Changes: https://git.openjdk.org/jdk/pull/19071/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19071&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8331605
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: htt