Re: RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-25 Thread Jaikiran Pai
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote: > In the hashN usages of readCen from zip_util.c we see a lot of signed integer > overflows. > For example in the java/util jtreg tests those are easily reproducable when > compiling with -ftrapv (clang/gcc toolchains). > While those ove

Re: RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-25 Thread Matthias Baesken
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote: > In the hashN usages of readCen from zip_util.c we see a lot of signed integer > overflows. > For example in the java/util jtreg tests those are easily reproducable when > compiling with -ftrapv (clang/gcc toolchains). > While those ove

Re: RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-25 Thread Martin Doerr
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote: > In the hashN usages of readCen from zip_util.c we see a lot of signed integer > overflows. > For example in the java/util jtreg tests those are easily reproducable when > compiling with -ftrapv (clang/gcc toolchains). > While those ove

Re: RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-24 Thread Jaikiran Pai
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote: > In the hashN usages of readCen from zip_util.c we see a lot of signed integer > overflows. > For example in the java/util jtreg tests those are easily reproducable when > compiling with -ftrapv (clang/gcc toolchains). > While those ove

Re: RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-24 Thread Lutz Schmidt
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote: > In the hashN usages of readCen from zip_util.c we see a lot of signed integer > overflows. > For example in the java/util jtreg tests those are easily reproducable when > compiling with -ftrapv (clang/gcc toolchains). > While those ove

RFR: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

2024-04-23 Thread Matthias Baesken
In the hashN usages of readCen from zip_util.c we see a lot of signed integer overflows. For example in the java/util jtreg tests those are easily reproducable when compiling with -ftrapv (clang/gcc toolchains). While those overflows never seem to cause crashes or similar errors, they are unwant