Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v4]

2024-04-17 Thread Naoto Sato
On Wed, 17 Apr 2024 17:16:55 GMT, Justin Lu wrote: >> Please review this PR which is a large spec reformatting for >> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat >> and CompactNumberFormat. >> >> The motivation for this change was the difficulty of readability f

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v4]

2024-04-17 Thread Justin Lu
> Please review this PR which is a large spec reformatting for > _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat > and CompactNumberFormat. > > The motivation for this change was the difficulty of readability for these > classes. This PR consists of changes such as b

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Naoto Sato
On Tue, 16 Apr 2024 22:30:47 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/CompactNumberFormat.java line 78: >> >>> 76: * installed. Thus, to use an instance method defined by {@code >>> CompactNumberFormat}, >>> 77: * the {@code NumberFormat} returned by the factory method s

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Justin Lu
On Tue, 16 Apr 2024 21:14:28 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains five commits: >> >> - merge master and add setStrict() to nFmt class spec >> - implement suggestions from dFmt revi

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v3]

2024-04-16 Thread Justin Lu
> Please review this PR which is a large spec reformatting for > _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat > and CompactNumberFormat. > > The motivation for this change was the difficulty of readability for these > classes. This PR consists of changes such as b

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Naoto Sato
On Tue, 16 Apr 2024 17:06:50 GMT, Justin Lu wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains five commits: >> >> - merge master and add setStrict() to nFmt class spec >> - implement suggestions from dFmt revie

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Naoto Sato
On Tue, 16 Apr 2024 17:12:06 GMT, Justin Lu wrote: >> Please review this PR which is a large spec reformatting for >> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat >> and CompactNumberFormat. >> >> The motivation for this change was the difficulty of readability f

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Justin Lu
On Mon, 15 Apr 2024 18:43:29 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains five commits: >> >> - merge master and add setStrict() to nFmt class spec >> - implement suggestions from dFmt revi

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Justin Lu
On Tue, 16 Apr 2024 17:09:04 GMT, Justin Lu wrote: >> Please review this PR which is a large spec reformatting for >> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat >> and CompactNumberFormat. >> >> The motivation for this change was the difficulty of readability f

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates [v2]

2024-04-16 Thread Justin Lu
> Please review this PR which is a large spec reformatting for > _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat > and CompactNumberFormat. > > The motivation for this change was the difficulty of readability for these > classes. This PR consists of changes such as b

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates

2024-04-15 Thread Naoto Sato
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote: > Please review this PR which is a large spec reformatting for > _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat > and CompactNumberFormat. > > The motivation for this change was the difficulty of readability for th

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates

2024-04-15 Thread Naoto Sato
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote: > Please review this PR which is a large spec reformatting for > _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat > and CompactNumberFormat. > > The motivation for this change was the difficulty of readability for th

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates

2024-04-12 Thread Justin Lu
On Fri, 12 Apr 2024 20:58:07 GMT, Naoto Sato wrote: >> Please review this PR which is a large spec reformatting for >> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat >> and CompactNumberFormat. >> >> The motivation for this change was the difficulty of readability

Re: RFR: 8329222: java.text.NumberFormat (and subclasses) spec updates

2024-04-12 Thread Naoto Sato
On Wed, 10 Apr 2024 20:16:50 GMT, Justin Lu wrote: > Please review this PR which is a large spec reformatting for > _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat > and CompactNumberFormat. > > The motivation for this change was the difficulty of readability for th