Re: RFR: 8325340: Add ASCII fast-path to Data-/ObjectInputStream.readUTF [v5]

2024-02-15 Thread Raffaello Giulietti
On Thu, 15 Feb 2024 10:33:07 GMT, Claes Redestad wrote: >> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via >> Data- and ObjectInputStream >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8325340: Add ASCII fast-path to Data-/ObjectInputStream.readUTF [v5]

2024-02-15 Thread Raffaello Giulietti
On Thu, 15 Feb 2024 10:55:38 GMT, Raffaello Giulietti wrote: >> The specification is somewhat ambiguous: >> https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/DataInput.html#readUTF() >> >> There's a sweeping `Throws UTFDataFormatException - if the bytes do not >> represent a

Re: RFR: 8325340: Add ASCII fast-path to Data-/ObjectInputStream.readUTF [v5]

2024-02-15 Thread Raffaello Giulietti
On Wed, 14 Feb 2024 14:30:02 GMT, Claes Redestad wrote: >> Ah OK. >> >> I didn't check the current code, only the proposed one. >> Although the specification clearly states that the method should throw, if >> the current code does not throw on zeros, then it makes sense that the >> proposed on

Re: RFR: 8325340: Add ASCII fast-path to Data-/ObjectInputStream.readUTF [v5]

2024-02-15 Thread Claes Redestad
On Thu, 15 Feb 2024 10:33:07 GMT, Claes Redestad wrote: >> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via >> Data- and ObjectInputStream >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8325340: Add ASCII fast-path to Data-/ObjectInputStream.readUTF [v5]

2024-02-15 Thread Claes Redestad
> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via > Data- and ObjectInputStream > > Testing: tier1-3 Claes Redestad has updated the pull request incrementally with one additional commit since the last revision: Revert spurious formatting changes - Chang