On Wed, 31 Jul 2024 15:51:48 GMT, Lance Andersen wrote:
>> Another (more conservative) possibility is to preserve both 1 ("Trailing
>> garbage is ignored") and 3 ("Concatenated streams are automatically
>> decoded") in the default configuration.
>>
>> Then basically all we would be changing is
On Wed, 31 Jul 2024 15:51:48 GMT, Lance Andersen wrote:
>> Another (more conservative) possibility is to preserve both 1 ("Trailing
>> garbage is ignored") and 3 ("Concatenated streams are automatically
>> decoded") in the default configuration.
>>
>> Then basically all we would be changing is
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Fri, 2 Aug 2024 13:12:00 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor to eliminate "lenient" mode (still failng test: GZIPInZip.java).
>> - Add GZIP input test for various gzip(1
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Tue, 30 Jul 2024 19:00:13 GMT, Archie Cobbs wrote:
> Another (more conservative) possibility is to preserve both 1 ("Trailing
> garbage is ignored") and 3 ("Concatenated streams are automatically decoded")
> in the default configuration.
>
> Then basically all we would be changing is no lon
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Tue, 30 Jul 2024 17:35:33 GMT, Lance Andersen wrote:
> Based on the above, I am reluctant to change the current behavior given it
> appears to have been modeled after gzip/gunzip as well as WinZip.
That's a reasonable conclusion... and I have no problem with preserving the
existing behavior
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
On Mon, 29 Jul 2024 14:27:28 GMT, Lance Andersen wrote:
> ... we really need more datapoint to better understand the risks/benefits in
> order to make an informed decision.
Agreed.
Here's some what I've come up with after a little bit of research:
First, we shouldn't confuse GZIP with ZIP fil
On Mon, 29 Jul 2024 13:52:57 GMT, Archie Cobbs wrote:
> > So where does that leave us:
> > Keep the code as is and document the current behavior
> > Continue to add additional test coverage for the current API
> > We probably do not need a new constructor given it probably adds no new
> > additi
On Mon, 29 Jul 2024 13:06:24 GMT, Lance Andersen wrote:
> So where does that leave us:
>
>Keep the code as is and document the current behavior
>Continue to add additional test coverage for the current API
>We probably do not need a new constructor given it probably adds no new
> ad
On Sat, 27 Jul 2024 15:00:51 GMT, Archie Cobbs wrote:
>> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
>> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
>> order to do this, after a GZIP trailer frame is read, it attempts to read a
>
> `GZIPInputStream` supports reading data from multiple concatenated GZIP data
> streams since [JDK-4691425](https://bugs.openjdk.org/browse/JDK-4691425). In
> order to do this, after a GZIP trailer frame is read, it attempts to read a
> GZIP header frame and, if successful, proceeds onward to d
16 matches
Mail list logo
