Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-05 Thread Claes Redestad
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Vladimir Kozlov
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Claes Redestad
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Vladimir Kozlov
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Claes Redestad
On Fri, 2 Feb 2024 18:45:22 GMT, Vladimir Kozlov wrote: > I don't see x86 changes. Why? The 2-byte variants for `string_equals`, if they ever existed, seems to be gone: // fast string equals instruct string_equals(rdi_RegP str1, rsi_RegP str2, rcx_RegI cnt, rax_RegI result,

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Vladimir Kozlov
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Claes Redestad
On Fri, 2 Feb 2024 14:53:51 GMT, Roger Riggs wrote: > LGTM for the core-libs point of view. (And what I understand of the assembler) Thanks! I'll try to get someone from the compiler team to look over the assembler change. @TobiHartmann, can you help get some eyes on this? - PR C

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Roger Riggs
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2024-02-02 Thread Claes Redestad
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

Re: RFR: 8321468: Remove StringUTF16::equals

2023-12-07 Thread Claes Redestad
On Wed, 6 Dec 2023 14:20:14 GMT, Claes Redestad wrote: > https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of > `StringUTF16::equals`. At the time I did some performance verification > focused on x86 showing that simplifying and only using `StringLatin1::equals` > was either neu

RFR: 8321468: Remove StringUTF16::equals

2023-12-07 Thread Claes Redestad
https://bugs.openjdk.org/browse/JDK-8215017 removed the only use of `StringUTF16::equals`. At the time I did some performance verification focused on x86 showing that simplifying and only using `StringLatin1::equals` was either neutral or a win. I repeated this experiment recently, adding some