On Thu, 30 Nov 2023 21:51:19 GMT, Naoto Sato wrote:
>> Removing the unnecessary array assignments.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill()
LGTM
-
Marked as reviewed by rriggs (Reviewer
On Thu, 30 Nov 2023 21:47:27 GMT, Naoto Sato wrote:
> > Is that "XXX" reminder at line 58 in MergeCollation still pertinent or
> > could it be removed?
>
> Maybe, but not 100% sure, so I just left it.
If unsure, better to leave it.
-
PR Comment: https://git.openjdk.org/jdk/pull/1
On Thu, 30 Nov 2023 21:51:19 GMT, Naoto Sato wrote:
>> Removing the unnecessary array assignments.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use Arrays.fill()
Marked as reviewed by bpb (Reviewer).
-
PR Re
> Removing the unnecessary array assignments.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Use Arrays.fill()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16912/files
- new: https://git.openjdk.org/jdk/pull/169
On Thu, 30 Nov 2023 21:17:57 GMT, Brian Burkhalter wrote:
> Is that "XXX" reminder at line 58 in MergeCollation still pertinent or could
> it be removed?
Maybe, but not 100% sure, so I just left it.
-
PR Comment: https://git.openjdk.org/jdk/pull/16912#issuecomment-1834615018
On Thu, 30 Nov 2023 21:26:20 GMT, Brett Okken wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use Arrays.fill()
>
> src/java.base/share/classes/sun/text/CompactByteArray.java line 83:
>
>> 81: for (i = 0
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
src/java.base/share/classes/sun/text/CompactByteArray.java line 83:
> 81: for (i = 0; i < UNICODECOUNT; ++i) {
> 82: values[i] = defaultValue;
> 83: }
shoul
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
Looks fine.
Is that "XXX" reminder at line 58 in MergeCollation still pertinent or could it
be removed?
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jd
On Thu, 30 Nov 2023 20:46:12 GMT, Naoto Sato wrote:
> Removing the unnecessary array assignments.
Looks good
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/16912#pullrequestreview-1758458649
Removing the unnecessary array assignments.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/16912/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16912&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8321059
Stats: 8 lines in 2 files cha
10 matches
Mail list logo
