Re: RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Hao Sun
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc Thanks for your reviews. - PR Comment: https://git.openj

Re: RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Jorn Vernee
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc Thanks. - Marked as reviewed by jvernee (Reviewer). PR

Re: RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread David Holmes
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc Looks good and trivial. Thanks for fixing. - Marked as r

RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Hao Sun
The fix is trivial. We should include the standard C header `stdlib.h` [1], rather than non-standard one `malloc.h`. [1] https://en.cppreference.com/w/c/memory/malloc - Commit messages: - 8320131: Zero build fails on macOS after JDK-8254693 Changes: https://git.openjdk.org/jdk/pul