On Wed, 8 Nov 2023 13:39:10 GMT, Daniel Fuchs wrote:
>> I agree, and I have looked into it, but I think it's better to do that
>> refactorization separately as it will impact other events.
>
> Just for my own understanding: in this particular case the time stamp is
> meaningless because the dur
On Wed, 8 Nov 2023 05:34:47 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62:
>>
>>> 60: if (ExceptionThrownEvent.enabled()) {
>>> 61: long timestamp = ExceptionThrownEvent.timestamp();
>>> 62: ExceptionThrownE
On Wed, 8 Nov 2023 05:13:04 GMT, David Holmes wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename field from tracing to jfrTracing
>
> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62:
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
Erik Gahlin has updated the pull request incrementally with one additional
commit since the last revision:
Rename field from tracing to jfrTracing
-
On Tue, 7 Nov 2023 09:27:51 GMT, Alan Bateman wrote:
>> I filed an issue to investigate if there is a problem with SOE, or if the
>> OOM check is really needed now.
>> https://bugs.openjdk.org/browse/JDK-8319579
>>
>> Regardless of outcome, It would be good to document the results of the
>> in
On Tue, 7 Nov 2023 09:24:20 GMT, Alan Bateman wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove SecurityException and IllegalArgumentException from throws clause
>
> src/java.base/share/classes/java/lang/Throwa
On Tue, 7 Nov 2023 02:10:29 GMT, Erik Gahlin wrote:
> I filed an issue to investigate if there is a problem with SOE, or if the OOM
> check is really needed now. https://bugs.openjdk.org/browse/JDK-8319579
>
> Regardless of outcome, It would be good to document the results of the
> investigati
On Mon, 6 Nov 2023 22:52:50 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
On Mon, 6 Nov 2023 22:41:17 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 44:
>>
>>> 42:
>>> 43: public static void traceError(Class clazz, String message) {
>>> 44: if (OutOfMemoryError.class.isAssignableFrom(clazz)) {
>>
>> St
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
Erik Gahlin has updated the pull request incrementally with one additional
commit since the last revision:
Remove SecurityException and IllegalArgume
On Mon, 6 Nov 2023 15:49:02 GMT, Alan Bateman wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
>
>> 35:
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private sta
Could I have a review of a PR that removes the bytecode instrumentation for the
exception events.
Testing: jdk/jdk/jfr + tier1 + tier2
-
Commit messages:
- Remove Throwable and Error from instrumentation list
- Initial
Changes: https://git.openjdk.org/jdk/pull/16493/files
Webrev
16 matches
Mail list logo
