Re: RFR: 8319316: Clarify text around which layouts a linker supports [v3]

2023-11-06 Thread Jorn Vernee
On Mon, 6 Nov 2023 10:13:14 GMT, Per Minborg wrote: >> Jorn Vernee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add 'strict' >> >> Co-authored-by: Maurizio Cimadamore >> <54672762+mcimadam...@users.noreply.github.com> > > Can we

Re: RFR: 8319316: Clarify text around which layouts a linker supports [v3]

2023-11-06 Thread Per Minborg
On Fri, 3 Nov 2023 18:16:17 GMT, Jorn Vernee wrote: >> - Add linker note about packed structs. >> - Relax language a bit to avoid implying that only listed layouts are >> supported. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8319316: Clarify text around which layouts a linker supports [v3]

2023-11-03 Thread Maurizio Cimadamore
On Fri, 3 Nov 2023 18:16:17 GMT, Jorn Vernee wrote: >> - Add linker note about packed structs. >> - Relax language a bit to avoid implying that only listed layouts are >> supported. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8319316: Clarify text around which layouts a linker supports [v3]

2023-11-03 Thread Jorn Vernee
> - Add linker note about packed structs. > - Relax language a bit to avoid implying that only listed layouts are > supported. Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: Add 'strict' Co-authored-by: Maurizio Cimadamore <546

Re: RFR: 8319316: Clarify text around which layouts a linker supports [v2]

2023-11-03 Thread Maurizio Cimadamore
On Fri, 3 Nov 2023 16:35:18 GMT, Jorn Vernee wrote: >> - Add linker note about packed structs. >> - Relax language a bit to avoid implying that only listed layouts are >> supported. > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8319316: Clarify text around which layouts a linker supports [v2]

2023-11-03 Thread Jorn Vernee
On Fri, 3 Nov 2023 16:17:32 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/foreign/Linker.java line 247: >> >>> 245: * >>> 246: * >>> 247: * Linker implementations may optionally support additional layouts, >>> such as 'packed' struct layouts. >> >> Optional: should we sa

Re: RFR: 8319316: Clarify text around which layouts a linker supports [v2]

2023-11-03 Thread Jorn Vernee
> - Add linker note about packed structs. > - Relax language a bit to avoid implying that only listed layouts are > supported. Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision: add examples of packed structs - Changes: -

Re: RFR: 8319316: Clarify text around which layouts a linker supports

2023-11-03 Thread Jorn Vernee
On Fri, 3 Nov 2023 14:48:31 GMT, Maurizio Cimadamore wrote: >> - Add linker note about packed structs. >> - Relax language a bit to avoid implying that only listed layouts are >> supported. > > src/java.base/share/classes/java/lang/foreign/Linker.java line 247: > >> 245: * >> 246: * >> 247:

Re: RFR: 8319316: Clarify text around which layouts a linker supports

2023-11-03 Thread Maurizio Cimadamore
On Fri, 3 Nov 2023 00:10:48 GMT, Jorn Vernee wrote: > - Add linker note about packed structs. > - Relax language a bit to avoid implying that only listed layouts are > supported. src/java.base/share/classes/java/lang/foreign/Linker.java line 247: > 245: * > 246: * > 247: * Linker implement

RFR: 8319316: Clarify text around which layouts a linker supports

2023-11-03 Thread Jorn Vernee
- Add linker note about packed structs. - Relax language a bit to avoid implying that only listed layouts are supported. - Commit messages: - simplify language - - Add linker note about packed structs. Changes: https://git.openjdk.org/jdk/pull/16485/files Webrev: https://webrevs.o