Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v5]

2023-11-09 Thread Joe Darcy
On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the las

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v5]

2023-11-07 Thread Roger Riggs
On Fri, 3 Nov 2023 19:14:18 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the las

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v5]

2023-11-03 Thread Raffaello Giulietti
> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by > improving guarantees of internal invariants. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Changed behavior on len == 0. - Changes:

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

2023-11-03 Thread Raffaello Giulietti
On Fri, 3 Nov 2023 09:01:48 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/java/math/BigInteger.java line 344: >> >>> 342: * @param len the number of bytes to use. >>> 343: * @throws NumberFormatException {@code val} is zero bytes long, >>> 344: * or {@co

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v4]

2023-11-03 Thread Raffaello Giulietti
> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by > improving guarantees of internal invariants. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Better formatting for empty loop bodies. -

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

2023-11-03 Thread Raffaello Giulietti
On Thu, 2 Nov 2023 22:21:15 GMT, Roger Riggs wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restored ordering of exceptions. > > src/java.base/share/classes/java/math/BigInteger.java line 344: > >> 342:

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

2023-11-02 Thread Roger Riggs
On Thu, 2 Nov 2023 14:25:20 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the las

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v3]

2023-11-02 Thread Raffaello Giulietti
> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by > improving guarantees of internal invariants. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Restored ordering of exceptions. - Change

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v2]

2023-11-01 Thread Joe Darcy
On Wed, 1 Nov 2023 14:52:23 GMT, Raffaello Giulietti wrote: >> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by >> improving guarantees of internal invariants. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the las

Re: RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors [v2]

2023-11-01 Thread Raffaello Giulietti
> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by > improving guarantees of internal invariants. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Static Random instance. - Changes: - al

RFR: 8319174: Enhance robustness of some j.m.BigInteger constructors

2023-11-01 Thread Raffaello Giulietti
Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by improving guarantees of internal invariants. - Commit messages: - Added @bug to test. - Refactored test to JUnit. - 8319174: Enhance robustness of some j.m.BigInteger constructors - Merge branch 'master' -