Re: RFR: 8316641: VarHandle template classes can share code in the base class [v8]

2023-12-04 Thread Paul Sandoz
On Mon, 4 Dec 2023 14:58:34 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/invoke/X-VarHandleByteArrayView.java.template >> line 594: >> >>> 592: @ForceInline >>> 593: static int indexRO(ByteBuffer bb, int index) { >>> 594: if (bb.isReadOnly()) >>

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v8]

2023-12-04 Thread Jorn Vernee
On Mon, 4 Dec 2023 14:49:39 GMT, Jorn Vernee wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> cleanup/vh-template-share >>

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v8]

2023-12-04 Thread Jorn Vernee
On Mon, 6 Nov 2023 08:19:19 GMT, Chen Liang wrote: >> VarHandle implementations have many static fields and methods that can be >> pulled to the common superclass to avoid repeated initialization and code >> duplication. >> >> In addition, the Unsafe-based Buffer field access are replaced by u

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v8]

2023-11-06 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v7]

2023-10-13 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v6]

2023-10-12 Thread Chen Liang
On Sun, 24 Sep 2023 13:16:02 GMT, Chen Liang wrote: >> VarHandle implementations have many static fields and methods that can be >> pulled to the common superclass to avoid repeated initialization and code >> duplication. >> >> In addition, the Unsafe-based Buffer field access are replaced by

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v6]

2023-09-24 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v5]

2023-09-24 Thread Chen Liang
On Sun, 24 Sep 2023 02:11:50 GMT, Chen Liang wrote: >> VarHandle implementations have many static fields and methods that can be >> pulled to the common superclass to avoid repeated initialization and code >> duplication. >> >> In addition, the Unsafe-based Buffer field access are replaced by

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v5]

2023-09-23 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v4]

2023-09-23 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v2]

2023-09-21 Thread Chen Liang
On Thu, 21 Sep 2023 08:50:00 GMT, Chen Liang wrote: >> VarHandle implementations have many static fields and methods that can be >> pulled to the common superclass to avoid repeated initialization and code >> duplication. >> >> In addition, the Unsafe-based Buffer field access are replaced by

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v3]

2023-09-21 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v2]

2023-09-21 Thread Jorn Vernee
On Thu, 21 Sep 2023 08:50:00 GMT, Chen Liang wrote: >> VarHandle implementations have many static fields and methods that can be >> pulled to the common superclass to avoid repeated initialization and code >> duplication. >> >> In addition, the Unsafe-based Buffer field access are replaced by

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v2]

2023-09-21 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

RFR: 8316641: VarHandle template classes can share code in the base class

2023-09-20 Thread Chen Liang
VarHandle implementations have many static fields and methods that can be pulled to the common superclass to avoid repeated initialization and code duplication. In addition, the Unsafe-based Buffer field access are replaced by usage of public methods or JavaNioAccess. - Commit mes